linux-kernel - Re: [PATCH 06/21] x86/ftrace: Add UNWIND_HINT_FUNC annotation for ftrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210114154221.4d6223e1@gandalf.local.home>
Date:   Thu, 14 Jan 2021 15:42:21 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Sami Tolvanen <samitolvanen@...gle.com>,
        Sedat Dilek <sedat.dilek@...il.com>,
        Kees Cook <keescook@...omium.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        clang-built-linux@...glegroups.com, Miroslav Benes <mbenes@...e.cz>
Subject: Re: [PATCH 06/21] x86/ftrace: Add UNWIND_HINT_FUNC annotation for
 ftrace_stub

On Thu, 14 Jan 2021 13:40:02 -0600
Josh Poimboeuf <jpoimboe@...hat.com> wrote:

> Prevent an unreachable objtool warning after the sibling call detection
> gets improved.  ftrace_stub() is basically a function, annotate it as
> such.
> 
> Cc: Steven Rostedt <rostedt@...dmis.org>

Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve

> Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com>
> ---
>  arch/x86/kernel/ftrace_64.S | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/kernel/ftrace_64.S b/arch/x86/kernel/ftrace_64.S
> index 0d54099c2a3a..58d125ed9d1a 100644
> --- a/arch/x86/kernel/ftrace_64.S
> +++ b/arch/x86/kernel/ftrace_64.S
> @@ -184,6 +184,7 @@ SYM_INNER_LABEL(ftrace_graph_call, SYM_L_GLOBAL)
>   * It is also used to copy the retq for trampolines.
>   */
>  SYM_INNER_LABEL_ALIGN(ftrace_stub, SYM_L_WEAK)
> +	UNWIND_HINT_FUNC
>  	retq
>  SYM_FUNC_END(ftrace_epilogue)
>