linux-kernel - Re: [PATCH v2 3/4] kunit: tool: use `with open()` in unit test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFd5g47+1o4W4Dq_pH4eN5-qGgO5gBGj-6kpMkHQ4ESSXHCGSA@mail.gmail.com>
Date:   Thu, 14 Jan 2021 14:19:57 -0800
From:   Brendan Higgins <brendanhiggins@...gle.com>
To:     Daniel Latypov <dlatypov@...gle.com>
Cc:     David Gow <davidgow@...gle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2 3/4] kunit: tool: use `with open()` in unit test

On Wed, Dec 2, 2020 at 11:09 AM Daniel Latypov <dlatypov@...gle.com> wrote:
>
> The use of manual open() and .close() calls seems to be an attempt to
> keep the contents in scope.
> But Python doesn't restrict variables like that, so we can introduce new
> variables inside of a `with` and use them outside.
>
> Do so to make the code more Pythonic.
>
> Signed-off-by: Daniel Latypov <dlatypov@...gle.com>

Tested-by: Brendan Higgins <brendanhiggins@...gle.com>
Acked-by: Brendan Higgins <brendanhiggins@...gle.com>