linux-kernel - Re: [PATCH v4 2/2] Input: cros-ec-keyb - Expose function row physical map to userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <161058839125.3661239.15252566946929589144@swboyd.mtv.corp.google.com>
Date:   Wed, 13 Jan 2021 17:39:51 -0800
From:   Stephen Boyd <swboyd@...omium.org>
To:     Philip Chen <philipchen@...omium.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Douglas Anderson <dianders@...omium.org>,
        Benson Leung <bleung@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Guenter Roeck <groeck@...omium.org>,
        Lee Jones <lee.jones@...aro.org>, linux-input@...r.kernel.org
Subject: Re: [PATCH v4 2/2] Input: cros-ec-keyb - Expose function row physical map to userspace

Quoting Philip Chen (2021-01-13 17:29:05)
> On Wed, Jan 13, 2021 at 3:14 PM Stephen Boyd <swboyd@...omium.org> wrote:
> >
> > Quoting Philip Chen (2021-01-13 14:47:18)
> > > On Tue, Jan 12, 2021 at 10:49 PM Stephen Boyd <swboyd@...omium.org> wrote:
> > > >
> > > > Quoting Philip Chen (2021-01-12 15:55:28)
> > > > > On Mon, Jan 11, 2021 at 6:24 PM Stephen Boyd <swboyd@...omium.org> wrote:
> > > > > >
> > > > > > Is it documented in Documentation/ABI/?
> > > > > Not yet.
> > > > > Is it proper to add the documentation to `testing/sysfs-driver-input-keyboard`?
> > > >
> > > > Somewhere in testing is fine. I'm not sure if it is a generic proprty
> > > > for all keyboards though? What's the path in sysfs?
> > > I wouldn't say it's generic.
> > > It is available in the keyboard device node only when the board has a
> > > custom top-row keyboard design.
> > > The path in sysfs is something like:
> > > /sys/class/input/input0/device/function_row_physmap, where input0 is
> > > cros_ec.
> >
> > I see that atkbd already has this so at least it would be common to some
> > sort of keyboard device. I'm not sure where to document it though. I see
> > that atkbd has a handful of undocumented sysfs attributes so adding all
> > of those may lead to a common path. At the least it sounds OK to have a
> > sysfs-driver-input-keyboard file if input folks are OK with it.
> Since there are other undocumented sysfs attributes for input/keyboard
> anyway, we should probably leave the documentation to another patch?
> For now, let's move to patch v5, where I've addressed all of the
> comments so far.

Please document this one that's being introduced. We should document all
the sysfs attributes but we don't always do a good job at it.