linux-kernel - Re: [PATCH v2 1/2] perf tools: add 'perf irq' to measure the hardware interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4ad7a048-8982-577b-b7c0-ca7e25f901d6@huawei.com>
Date:   Thu, 14 Jan 2021 12:32:05 +0300
From:   Alexei Budankov <abudankov@...wei.com>
To:     Bixuan Cui <cuibixuan@...wei.com>, <peterz@...radead.org>,
        <mingo@...hat.com>, <acme@...nel.org>, <mark.rutland@....com>,
        <alexander.shishkin@...ux.intel.com>, <jolsa@...hat.com>,
        <namhyung@...nel.org>, <linux-kernel@...r.kernel.org>
CC:     <john.wanghui@...wei.com>
Subject: Re: [PATCH v2 1/2] perf tools: add 'perf irq' to measure the hardware
 interrupts


On 14.01.2021 10:48, Bixuan Cui wrote:
> Add 'perf irq' to trace/measure the hardware interrupts.
> 
> Now three functions are provided:
>   1. 'perf irq record <command>' to record the irq handler events.
>   2. 'perf irq script' to see a detailed trace of the workload that
>    was recorded.
>   3. 'perf irq report' to calculate the time consumed by each
>    hardware interrupt processing function.
> 
> Signed-off-by: Bixuan Cui <cuibixuan@...wei.com>
> ---
>  tools/perf/Build         |   1 +
>  tools/perf/builtin-irq.c | 287 +++++++++++++++++++++++++++++++++++++++
>  tools/perf/builtin.h     |   1 +
>  tools/perf/perf.c        |   1 +
>  4 files changed, 290 insertions(+)
>  create mode 100644 tools/perf/builtin-irq.c

<SNIP>

> +static int __cmd_record(int argc, const char **argv)
> +{
> +	unsigned int rec_argc, i, j;
> +	const char **rec_argv;
> +	const char * const record_args[] = {
> +		"record",
> +		"-a",

Could you please make it configurable from the command line 
jointly with -p option?

> +		"-R",
> +		"-c", "1",
> +		"-e", "irq:irq_handler_entry",
> +		"-e", "irq:irq_handler_exit",
> +	};

Thanks,
Alexei