linux-kernel - RE: [Intel-wired-lan] [net-next] net: iavf: Use the ARRAY_SIZE macro for aq_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY4PR11MB15769D5697074F230C8742CAABA80@CY4PR11MB1576.namprd11.prod.outlook.com>
Date:   Thu, 14 Jan 2021 09:57:28 +0000
From:   "Jankowski, Konrad0" <konrad0.jankowski@...el.com>
To:     Wei Xu <xuwei5@...ilicon.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "salil.mehta@...wei.com" <salil.mehta@...wei.com>,
        "jinying@...ilicon.com" <jinying@...ilicon.com>,
        "tangkunshan@...wei.com" <tangkunshan@...wei.com>,
        "huangdaode@...ilicon.com" <huangdaode@...ilicon.com>,
        "john.garry@...wei.com" <john.garry@...wei.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linuxarm@...wei.com" <linuxarm@...wei.com>,
        "shameerali.kolothum.thodi@...wei.com" 
        <shameerali.kolothum.thodi@...wei.com>,
        "zhangyi.ac@...wei.com" <zhangyi.ac@...wei.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "jonathan.cameron@...wei.com" <jonathan.cameron@...wei.com>,
        Jakub Kicinski <kuba@...nel.org>,
        "liguozhu@...ilicon.com" <liguozhu@...ilicon.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "shiju.jose@...wei.com" <shiju.jose@...wei.com>
Subject: RE: [Intel-wired-lan] [net-next] net: iavf: Use the ARRAY_SIZE macro
 for aq_to_posix


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Wei Xu
> Sent: środa, 9 września 2020 10:51
> To: netdev@...r.kernel.org
> Cc: salil.mehta@...wei.com; jinying@...ilicon.com;
> tangkunshan@...wei.com; huangdaode@...ilicon.com;
> john.garry@...wei.com; linux-kernel@...r.kernel.org;
> linuxarm@...wei.com; shameerali.kolothum.thodi@...wei.com;
> zhangyi.ac@...wei.com; intel-wired-lan@...ts.osuosl.org;
> xuwei5@...ilicon.com; jonathan.cameron@...wei.com; Jakub Kicinski
> <kuba@...nel.org>; liguozhu@...ilicon.com; davem@...emloft.net;
> shiju.jose@...wei.com
> Subject: [Intel-wired-lan] [net-next] net: iavf: Use the ARRAY_SIZE macro for
> aq_to_posix
> 
> Use the ARRAY_SIZE macro to calculate the size of an array.
> This code was detected with the help of Coccinelle.
> 
> Signed-off-by: Wei Xu <xuwei5@...ilicon.com>
> ---
>  drivers/net/ethernet/intel/iavf/iavf_adminq.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_adminq.h
> b/drivers/net/ethernet/intel/iavf/iavf_adminq.h
> index baf2fe2..eead12c 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_adminq.h
> +++ b/drivers/net/ethernet/intel/iavf/iavf_adminq.h
> @@ -120,7 +120,7 @@ static inline int iavf_aq_rc_to_posix(int aq_ret, int
> aq_rc)
>  	if (aq_ret == IAVF_ERR_ADMIN_QUEUE_TIMEOUT)
>  		return -EAGAIN;
> 
> -	if (!((u32)aq_rc < (sizeof(aq_to_posix) / sizeof((aq_to_posix)[0]))))
> +	if (!((u32)aq_rc < ARRAY_SIZE(aq_to_posix)))
>  		return -ERANGE;
> 
>  	return aq_to_posix[aq_rc];

Tested-by: Konrad Jankowski <konrad0.jankowski@...el.com>
---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Sowackiego 173 | 80-298 Gdask | Sd Rejonowy Gdask Pnoc | VII Wydzia Gospodarczy Krajowego Rejestru Sdowego - KRS 101882 | NIP 957-07-52-316 | Kapita zakadowy 200.000 PLN.
Ta wiadomo wraz z zacznikami jest przeznaczona dla okrelonego adresata i moe zawiera informacje poufne. W razie przypadkowego otrzymania tej wiadomoci, prosimy o powiadomienie nadawcy oraz trwae jej usunicie; jakiekolwiek przegldanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.