| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 Jan 2021 18:11:51 +0800
From: kernel test robot <lkp@...el.com>
To: Mauro Carvalho Chehab <mchehab@...nel.org>,
Linux Doc Mailing List <linux-doc@...r.kernel.org>,
Jonathan Corbet <corbet@....net>
Cc: kbuild-all@...ts.01.org, linux-media@...r.kernel.org,
Mauro Carvalho Chehab <mchehab@...nel.org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 11/16] scripts: kernel-doc: validate kernel-doc markup
with the actual names
Hi Mauro,
I love your patch! Perhaps something to improve:
[auto build test WARNING on next-20210113]
[also build test WARNING on v5.11-rc3]
[cannot apply to lwn/docs-next kees/for-next/pstore mac80211-next/master mac80211/master pza/reset/next linus/master v5.11-rc3 v5.11-rc2 v5.11-rc1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/Fix-several-bad-kernel-doc-markups/20210114-161010
base: aa515cdce7a151dcc14b7600d33f1414c6fa32c9
config: arm64-alldefconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/1e9159b3640012fc5fab8508b1c5635ac13a55e9
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mauro-Carvalho-Chehab/Fix-several-bad-kernel-doc-markups/20210114-161010
git checkout 1e9159b3640012fc5fab8508b1c5635ac13a55e9
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
kernel/seccomp.c:126: warning: Function parameter or member 'list' not described in 'seccomp_kaddfd'
kernel/seccomp.c:390: warning: Function parameter or member 'ret' not described in 'ACTION_ONLY'
>> kernel/seccomp.c:390: warning: expecting prototype for seccomp_run_filters(). Prototype was for ACTION_ONLY() instead
kernel/seccomp.c:553: warning: Function parameter or member 'tsk' not described in 'seccomp_filter_release'
kernel/seccomp.c:573: warning: Function parameter or member 'flags' not described in 'seccomp_sync_threads'
--
drivers/base/platform-msi.c:336: warning: Function parameter or member 'is_tree' not described in '__platform_msi_create_device_domain'
>> drivers/base/platform-msi.c:336: warning: expecting prototype for platform_msi_create_device_domain(). Prototype was for __platform_msi_create_device_domain() instead
--
>> drivers/iommu/iommu.c:956: warning: expecting prototype for iommu_group_for_each_dev(). Prototype was for __iommu_group_for_each_dev() instead
drivers/iommu/iommu.c:2976: warning: Function parameter or member 'drvdata' not described in 'iommu_sva_bind_device'
--
>> kernel/irq/msi.c:534: warning: expecting prototype for __msi_domain_free_irqs(). Prototype was for msi_domain_free_irqs() instead
--
>> kernel/irq/ipi.c:264: warning: expecting prototype for ipi_send_mask(). Prototype was for __ipi_send_mask() instead
vim +390 kernel/seccomp.c
f9d480b6ffbeb336 YiFei Zhu 2020-10-11 380
e2cfabdfd0756482 Will Drewry 2012-04-12 381 /**
285fdfc5d9959a21 Mickaël Salaün 2016-09-20 382 * seccomp_run_filters - evaluates all seccomp filters against @sd
285fdfc5d9959a21 Mickaël Salaün 2016-09-20 383 * @sd: optional seccomp data to be passed to filters
deb4de8b31bc5bf2 Kees Cook 2017-08-02 384 * @match: stores struct seccomp_filter that resulted in the return value,
deb4de8b31bc5bf2 Kees Cook 2017-08-02 385 * unless filter returned SECCOMP_RET_ALLOW, in which case it will
deb4de8b31bc5bf2 Kees Cook 2017-08-02 386 * be unchanged.
e2cfabdfd0756482 Will Drewry 2012-04-12 387 *
e2cfabdfd0756482 Will Drewry 2012-04-12 388 * Returns valid seccomp BPF response codes.
e2cfabdfd0756482 Will Drewry 2012-04-12 389 */
0466bdb99e8744bc Kees Cook 2017-08-11 @390 #define ACTION_ONLY(ret) ((s32)((ret) & (SECCOMP_RET_ACTION_FULL)))
deb4de8b31bc5bf2 Kees Cook 2017-08-02 391 static u32 seccomp_run_filters(const struct seccomp_data *sd,
deb4de8b31bc5bf2 Kees Cook 2017-08-02 392 struct seccomp_filter **match)
e2cfabdfd0756482 Will Drewry 2012-04-12 393 {
acf3b2c71ed20c53 Will Drewry 2012-04-12 394 u32 ret = SECCOMP_RET_ALLOW;
8225d3853f34f6cf Pranith Kumar 2014-11-21 395 /* Make sure cross-thread synced filter points somewhere sane. */
8225d3853f34f6cf Pranith Kumar 2014-11-21 396 struct seccomp_filter *f =
506458efaf153c1e Will Deacon 2017-10-24 397 READ_ONCE(current->seccomp.filter);
acf3b2c71ed20c53 Will Drewry 2012-04-12 398
acf3b2c71ed20c53 Will Drewry 2012-04-12 399 /* Ensure unexpected behavior doesn't result in failing open. */
0d42d73a37ff9102 Igor Stoppa 2018-09-05 400 if (WARN_ON(f == NULL))
4d3b0b05aae9ee9c Kees Cook 2017-08-11 401 return SECCOMP_RET_KILL_PROCESS;
acf3b2c71ed20c53 Will Drewry 2012-04-12 402
f9d480b6ffbeb336 YiFei Zhu 2020-10-11 403 if (seccomp_cache_check_allow(f, sd))
f9d480b6ffbeb336 YiFei Zhu 2020-10-11 404 return SECCOMP_RET_ALLOW;
f9d480b6ffbeb336 YiFei Zhu 2020-10-11 405
e2cfabdfd0756482 Will Drewry 2012-04-12 406 /*
e2cfabdfd0756482 Will Drewry 2012-04-12 407 * All filters in the list are evaluated and the lowest BPF return
acf3b2c71ed20c53 Will Drewry 2012-04-12 408 * value always takes priority (ignoring the DATA).
e2cfabdfd0756482 Will Drewry 2012-04-12 409 */
3ba2530cc06eb4ae Kees Cook 2014-06-27 410 for (; f; f = f->prev) {
3d9f773cf2876c01 David Miller 2020-02-24 411 u32 cur_ret = bpf_prog_run_pin_on_cpu(f->prog, sd);
8f577cadf7181243 Alexei Starovoitov 2014-05-13 412
0466bdb99e8744bc Kees Cook 2017-08-11 413 if (ACTION_ONLY(cur_ret) < ACTION_ONLY(ret)) {
acf3b2c71ed20c53 Will Drewry 2012-04-12 414 ret = cur_ret;
deb4de8b31bc5bf2 Kees Cook 2017-08-02 415 *match = f;
deb4de8b31bc5bf2 Kees Cook 2017-08-02 416 }
e2cfabdfd0756482 Will Drewry 2012-04-12 417 }
e2cfabdfd0756482 Will Drewry 2012-04-12 418 return ret;
e2cfabdfd0756482 Will Drewry 2012-04-12 419 }
1f41b450416e689b Kees Cook 2014-06-25 420 #endif /* CONFIG_SECCOMP_FILTER */
1f41b450416e689b Kees Cook 2014-06-25 421
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (10848 bytes)
Powered by blists - more mailing lists