linux-kernel - Re: [PATCH RFC 3/3] ipmi: remove open coded version of SMBus block write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210114140401.GA973@kunai>
Date:   Thu, 14 Jan 2021 15:04:01 +0100
From:   Wolfram Sang <wsa+renesas@...g-engineering.com>
To:     Corey Minyard <minyard@....org>
Cc:     linux-i2c@...r.kernel.org,
        openipmi-developer@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org,
        Colin Ian King <colin.king@...onical.com>,
        Vijay Khemka <vijaykhemka@...com>,
        Asmaa Mnebhi <Asmaa@...lanox.com>
Subject: Re: [PATCH RFC 3/3] ipmi: remove open coded version of SMBus block
 write


> I asked the original authors of this about the change, and apparently is
> results in a stack size warning.  Arnd Bergmann ask for it to be changed
> from what you are suggesting to what it currently is.  See:
> 
> https://www.lkml.org/lkml/2019/6/19/440
> 
> So apparently this change will cause compile warnings due to the size of
> struct i2c_client.

Wow, didn't know that my patch was actually a revert. I replaced now the
stack usage with kmemdup and will have a second thought about this
patch. Thanks for the heads up!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)