linux-kernel - Re: [PATCH V2 11/11] dts: bindings: Document device tree bindings for Arm TRBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210114140754.GA2816889@robh.at.kernel.org>
Date:   Thu, 14 Jan 2021 08:07:54 -0600
From:   Rob Herring <robh@...nel.org>
To:     Anshuman Khandual <anshuman.khandual@....com>
Cc:     linux-arm-kernel@...ts.infradead.org, coresight@...ts.linaro.org,
        mathieu.poirier@...aro.org, suzuki.poulose@....com,
        mike.leach@...aro.org, Linu Cherian <lcherian@...vell.com>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH V2 11/11] dts: bindings: Document device tree bindings
 for Arm TRBE

On Wed, Jan 13, 2021 at 09:48:18AM +0530, Anshuman Khandual wrote:
> From: Suzuki K Poulose <suzuki.poulose@....com>
> 
> Document the device tree bindings for Trace Buffer Extension (TRBE).
> 
> Cc: Anshuman Khandual <anshuman.khandual@....com>
> Cc: Mathieu Poirier <mathieu.poirier@...aro.org>
> Cc: Rob Herring <robh@...nel.org>
> Cc: devicetree@...r.kernel.org
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@....com>
> Signed-off-by: Anshuman Khandual <anshuman.khandual@....com>
> ---
>  Documentation/devicetree/bindings/arm/trbe.yaml | 46 +++++++++++++++++++++++++
>  1 file changed, 46 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/trbe.yaml
> 
> diff --git a/Documentation/devicetree/bindings/arm/trbe.yaml b/Documentation/devicetree/bindings/arm/trbe.yaml
> new file mode 100644
> index 0000000..2258595
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/trbe.yaml
> @@ -0,0 +1,46 @@
> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
> +# Copyright 2021, Arm Ltd
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/arm/trbe.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: ARM Trace Buffer Extensions
> +
> +maintainers:
> +  - Anshuman Khandual <anshuman.khandual@....com>
> +
> +description: |
> +  Description of TRBE hw

Huh?

> +
> +properties:
> +  $nodename:
> +    pattern: "trbe"

const: trbe

> +  compatible:
> +    items:
> +      - const: arm,trace-buffer-extension

Any versioning to this? Or is that discoverable?

> +
> +  interrupts:
> +    description: |
> +       Exactly 1 PPI must be listed. For heterogeneous systems where
> +       TRBE is only supported on a subset of the CPUs, please consult
> +       the arm,gic-v3 binding for details on describing a PPI partition.
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - interrupts
> +
> +additionalProperties: false
> +
> +

Extra blank line.

> +examples:
> +
> + - |
> +   #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +   trbe {
> +     compatible = "arm,trace-buffer-extension";
> +     interrupts = <GIC_PPI 15 IRQ_TYPE_LEVEL_HIGH>;
> +   };
> +...
> -- 
> 2.7.4
>