linux-kernel - Re: [PATCH v2 3/7] selftests: remove obsolete build restriction for gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMpxmJUrkX-nM1pNSrtCx-KKG0edBD1FGuaaRvLKqXZhN4u=Vw@mail.gmail.com>
Date:   Thu, 14 Jan 2021 16:04:57 +0100
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     Kent Gibson <warthog618@...il.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        linux-gpio <linux-gpio@...r.kernel.org>,
        linux-kselftest@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        Shuah Khan <shuah@...nel.org>,
        Bamvor Jian Zhang <bamv2005@...il.com>
Subject: Re: [PATCH v2 3/7] selftests: remove obsolete build restriction for gpio

On Thu, Jan 7, 2021 at 3:58 AM Kent Gibson <warthog618@...il.com> wrote:
>
> Build restrictions related to the gpio-mockup-chardev helper are
> no longer relevant so remove them.
>
> Signed-off-by: Kent Gibson <warthog618@...il.com>
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> ---
>  tools/testing/selftests/Makefile | 9 ---------
>  1 file changed, 9 deletions(-)
>
> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index d9c283503159..5411041e63a0 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -121,15 +121,6 @@ ARCH           ?= $(SUBARCH)
>  export KSFT_KHDR_INSTALL_DONE := 1
>  export BUILD
>
> -# build and run gpio when output directory is the src dir.
> -# gpio has dependency on tools/gpio and builds tools/gpio
> -# objects in the src directory in all cases making the src
> -# repo dirty even when objects are relocated.
> -ifneq (1,$(DEFAULT_INSTALL_HDR_PATH))
> -       TMP := $(filter-out gpio, $(TARGETS))
> -       TARGETS := $(TMP)
> -endif
> -
>  # set default goal to all, so make without a target runs all, even when
>  # all isn't the first target in the file.
>  .DEFAULT_GOAL := all
> --
> 2.30.0
>

Reviewed-by: Bartosz Golaszewski <bgolaszewski@...libre.com>