[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20210114152323.2382283-2-lee.jones@linaro.org>
Date: Thu, 14 Jan 2021 15:23:19 +0000
From: Lee Jones <lee.jones@...aro.org>
To: lee.jones@...aro.org
Cc: linux-kernel@...r.kernel.org,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
Henrik Rydberg <rydberg@...math.org>,
Peter Osterlund <petero2@...ia.com>,
Stefan Gmeiner <riddlebox@...esurf.ch>,
"C. Scott Ananian" <cananian@...mni.priceton.edu>,
Bruce Kalk <kall@...pass.com>,
this to <linux-input@...r.kernel.org>
Subject: [PATCH 1/5] input: mouse: synaptics: Replace NOOP with suitable commentary
Fixes the following W=1 kernel build warning(s):
drivers/input/mouse/synaptics.c: In function ‘synaptics_process_packet’:
drivers/input/mouse/synaptics.c:1110:6: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: Henrik Rydberg <rydberg@...math.org>
Cc: Peter Osterlund <petero2@...ia.com>
Cc: Stefan Gmeiner <riddlebox@...esurf.ch>
Cc: "C. Scott Ananian" <cananian@...mni.priceton.edu>
Cc: Bruce Kalk <kall@...pass.com>
Cc: this to <linux-input@...r.kernel.org>
Cc: linux-input@...r.kernel.org
Signed-off-by: Lee Jones <lee.jones@...aro.org>
---
drivers/input/mouse/synaptics.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 8fb7b4385ded9..3cc8b76629fa2 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -1106,8 +1106,11 @@ static void synaptics_process_packet(struct psmouse *psmouse)
num_fingers = hw.w + 2;
break;
case 2:
- if (SYN_MODEL_PEN(info->model_id))
- ; /* Nothing, treat a pen as a single finger */
+ /*
+ * Keep defaults
+ *
+ * SYN_MODEL_PEN: Treat pens as a single finger
+ */
break;
case 4 ... 15:
if (SYN_CAP_PALMDETECT(info->capabilities))
--
2.25.1
Powered by blists - more mailing lists