linux-kernel - Re: [PATCH v2] mtd: rawnand: intel: check the mtd name only after setting the variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20210114154758.32030-1-miquel.raynal@bootlin.com>
Date:   Thu, 14 Jan 2021 16:47:58 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        vadivel.muruganx.ramuthevar@...ux.intel.com,
        linux-mtd@...ts.infradead.org, miquel.raynal@...tlin.com
Cc:     richard@....at, vigneshr@...com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mtd: rawnand: intel: check the mtd name only after setting the variable

On Wed, 2021-01-06 at 14:09:43 UTC, Martin Blumenstingl wrote:
> Move the check for mtd->name after the mtd variable has actually been
> initialized.
> 
> While here, also drop the NULL assignment to the mtd variable as it's
> overwritten later on anyways and the NULL value is never read.
> 
> Fixes: 0b1039f016e8a3 ("mtd: rawnand: Add NAND controller support on Intel LGM SoC")
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks.

Miquel