linux-kernel - Re: [PATCH 4/5] input: touchscreen: surface3_spi: Remove set but unused variable 'timestamp'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Jan 2021 17:04:32 +0100
From:   Benjamin Tissoires <benjamin.tissoires@...il.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Henrik Rydberg <rydberg@...math.org>,
        linux-input <linux-input@...r.kernel.org>
Subject: Re: [PATCH 4/5] input: touchscreen: surface3_spi: Remove set but
 unused variable 'timestamp'

On Thu, Jan 14, 2021 at 4:23 PM Lee Jones <lee.jones@...aro.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/input/touchscreen/surface3_spi.c: In function ‘surface3_spi_process_touch’:
>  drivers/input/touchscreen/surface3_spi.c:97:6: warning: variable ‘timestamp’ set but not used [-Wunused-but-set-variable]
>
> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Cc: Henrik Rydberg <rydberg@...math.org>
> Cc: Benjamin Tissoires <benjamin.tissoires@...il.com>
> Cc: linux-input@...r.kernel.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Reviewed-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>

Thanks for the cleanup :)

Cheers,
Benjamin

> ---
>  drivers/input/touchscreen/surface3_spi.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/input/touchscreen/surface3_spi.c b/drivers/input/touchscreen/surface3_spi.c
> index 731454599fcee..1da23e5585a0d 100644
> --- a/drivers/input/touchscreen/surface3_spi.c
> +++ b/drivers/input/touchscreen/surface3_spi.c
> @@ -94,9 +94,7 @@ static void surface3_spi_report_touch(struct surface3_ts_data *ts_data,
>
>  static void surface3_spi_process_touch(struct surface3_ts_data *ts_data, u8 *data)
>  {
> -       u16 timestamp;
>         unsigned int i;
> -       timestamp = get_unaligned_le16(&data[15]);
>
>         for (i = 0; i < 13; i++) {
>                 struct surface3_ts_data_finger *finger;
> --
> 2.25.1
>