linux-kernel - Re: [PATCH][next] ALSA: usb-audio: remove initialization of param_period_time_if

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hsg72kxjk.wl-tiwai@suse.de>
Date:   Fri, 15 Jan 2021 16:52:15 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Colin King <colin.king@...onical.com>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        Alexander Tsoy <alexander@...y.me>,
        alsa-devel@...a-project.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] ALSA: usb-audio: remove initialization of param_period_time_if_needed

On Fri, 15 Jan 2021 16:41:51 +0100,
Colin King wrote:
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> Variable param_period_time_if_needed is being initialized with a value
> that is never read, the assignment is redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

This doesn't look applicable to the latest tree.
Could you check again?


thanks,

Takashi

> ---
>  sound/usb/pcm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
> index f71965bf815f..ed654338f6b7 100644
> --- a/sound/usb/pcm.c
> +++ b/sound/usb/pcm.c
> @@ -934,7 +934,7 @@ static int setup_hw_info(struct snd_pcm_runtime *runtime, struct snd_usb_substre
>  {
>  	const struct audioformat *fp;
>  	unsigned int pt, ptmin;
> -	int param_period_time_if_needed = -1;
> +	int param_period_time_if_needed;
>  	int err;
>  
>  	runtime->hw.formats = subs->formats;
> -- 
> 2.29.2
>