linux-kernel - Re: [PATCH v3 2/2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for HDMI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Jan 2021 19:18:17 -0800
From:   Stephen Boyd <swboyd@...omium.org>
To:     Srinivasa Rao Mandadapu <srivasam@...eaurora.org>,
        agross@...nel.org, bjorn.andersson@...aro.org,
        devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, robh+dt@...nel.org,
        rohitkr@...eaurora.org, srinivas.kandagatla@...aro.org
Cc:     V Sujith Kumar Reddy <vsujithk@...eaurora.org>,
        Srinivasa Rao Mandadapu <srivasam@...eaurora.org>
Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for HDMI

Quoting Srinivasa Rao Mandadapu (2020-09-29 23:42:48)
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> index 5724982..850b43e 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> @@ -231,6 +231,7 @@
>  
>                 audio-jack = <&alc5682>;
>  
> +               #sound-dai-cells = <0>;
>                 #address-cells = <1>;
>                 #size-cells = <0>;
>  
> @@ -257,6 +258,17 @@
>                                 sound-dai = <&max98357a>;
>                         };
>                 };

Can you please add a newline here?

> +               dai-link@2 {
> +                       link-name = "MultiMedia2";
> +                       reg = <2>;
> +                       cpu {
> +                               sound-dai = <&lpass_cpu 2>;
> +                       };
> +
> +                       codec {
> +                               sound-dai = <&msm_dp>;
> +                       };
> +               };
>         };
>  };
>  
> @@ -782,6 +794,9 @@ hp_i2c: &i2c9 {
>                 reg = <MI2S_SECONDARY>;
>                 qcom,playback-sd-lines = <0>;
>         };

Can you please add a newline here?

> +       hdmi-primary@0 {

This should be hdmi-primary@2 {

Or a more generic node name should be devised. dai@2 perhaps?

> +               reg = <LPASS_DP_RX>;
> +       };
>  };
>