linux-kernel - Re: [PATCH] audit: Remove leftover reference to the audit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHC9VhS=f93bcHQMtrpvEM=aqyKFf8gjRGpM6QkOO4r2gEpuCw@mail.gmail.com>
Date:   Fri, 15 Jan 2021 12:08:50 -0500
From:   Paul Moore <paul@...l-moore.com>
To:     Davidlohr Bueso <dave@...olabs.net>
Cc:     linux-audit@...hat.com, linux-kernel@...r.kernel.org,
        Davidlohr Bueso <dbueso@...e.de>
Subject: Re: [PATCH] audit: Remove leftover reference to the audit_tasklet

On Thu, Jan 14, 2021 at 7:12 PM Davidlohr Bueso <dave@...olabs.net> wrote:
>
> This was replaced with a kauditd_wait kthread long ago,
> back in:
>
>      b7d1125817c (AUDIT: Send netlink messages from a separate kernel thread)
>
> Update the stale comment.
>
> Signed-off-by: Davidlohr Bueso <dbueso@...e.de>
> ---
>  kernel/audit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Nice catch.  Merged into audit/next, thanks!

> diff --git a/kernel/audit.c b/kernel/audit.c
> index 1ffc2e059027..8fd735190c12 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -2365,7 +2365,7 @@ int audit_signal_info(int sig, struct task_struct *t)
>   *
>   * We can not do a netlink send inside an irq context because it blocks (last
>   * arg, flags, is not set to MSG_DONTWAIT), so the audit buffer is placed on a
> - * queue and a tasklet is scheduled to remove them from the queue outside the
> + * queue and a kthread is scheduled to remove them from the queue outside the
>   * irq context.  May be called in any context.
>   */
>  void audit_log_end(struct audit_buffer *ab)
> --
> 2.26.2

-- 
paul moore
www.paul-moore.com