linux-kernel - Re: [PATCH v3] cgroup-v1: add disabled controller check in cgroup1_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YAH25uulZr1BiQVc@mtj.duckdns.org>
Date:   Fri, 15 Jan 2021 15:11:18 -0500
From:   Tejun Heo <tj@...nel.org>
To:     Chen Zhou <chenzhou10@...wei.com>
Cc:     lizefan.x@...edance.com, hannes@...xchg.org, mkoutny@...e.com,
        viro@...iv.linux.org.uk, cgroups@...r.kernel.org,
        linux-kernel@...r.kernel.org, huawei.libin@...wei.com
Subject: Re: [PATCH v3] cgroup-v1: add disabled controller check in
 cgroup1_parse_param()

On Fri, Jan 15, 2021 at 05:37:17PM +0800, Chen Zhou wrote:
> When mounting a cgroup hierarchy with disabled controller in cgroup v1,
> all available controllers will be attached.
> For example, boot with cgroup_no_v1=cpu or cgroup_disable=cpu, and then
> mount with "mount -t cgroup -ocpu cpu /sys/fs/cgroup/cpu", then all
> enabled controllers will be attached except cpu.
> 
> Fix this by adding disabled controller check in cgroup1_parse_param().
> If the specified controller is disabled, just return error with information
> "Disabled controller xx" rather than attaching all the other enabled
> controllers.
> 
> Fixes: f5dfb5315d34 ("cgroup: take options parsing into ->parse_monolithic()")
> Signed-off-by: Chen Zhou <chenzhou10@...wei.com>
> Reviewed-by: Zefan Li <lizefan.x@...edance.com>

Applied to cgroup/for-5.11-fixes.

Thanks.

-- 
tejun