linux-kernel - Re: [PATCH] mips: vdso: fix DWARF2 warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210115201342.76nssqtbs4kttgts@google.com>
Date:   Fri, 15 Jan 2021 12:13:42 -0800
From:   Fangrui Song <maskray@...gle.com>
To:     Anders Roxell <anders.roxell@...aro.org>
Cc:     Nathan Chancellor <natechancellor@...il.com>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        linux-mips@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        clang-built-linux <clang-built-linux@...glegroups.com>,
        stable@...r.kernel.org
Subject: Re: [PATCH] mips: vdso: fix DWARF2 warning


On 2021-01-15, Anders Roxell wrote:
>On Fri, 15 Jan 2021 at 20:28, Nathan Chancellor
><natechancellor@...il.com> wrote:
>>
>> On Fri, Jan 15, 2021 at 08:13:30PM +0100, Anders Roxell wrote:
>> > When building mips tinyconifg the following warning show up
>> >
>> > make --silent --keep-going --jobs=8 O=/home/anders/src/kernel/next/out/builddir ARCH=mips CROSS_COMPILE=mips-linux-gnu- HOSTCC=clang CC=clang
>> > /srv/src/kernel/next/arch/mips/vdso/elf.S:14:1: warning: DWARF2 only supports one section per compilation unit
>> > .pushsection .note.Linux, "a",@note ; .balign 4 ; .long 2f - 1f ; .long 4484f - 3f ; .long 0 ; 1:.asciz "Linux" ; 2:.balign 4 ; 3:
>> > ^
>> > /srv/src/kernel/next/arch/mips/vdso/elf.S:34:2: warning: DWARF2 only supports one section per compilation unit
>> >  .section .mips_abiflags, "a"
>> >  ^
>> >
>> > Rework so the mips vdso Makefile adds flag '-no-integrated-as' unless
>> > LLVM_IAS is defined.
>> >
>> > Link: https://github.com/ClangBuiltLinux/linux/issues/1256
>> > Cc: stable@...r.kernel.org # v4.19+
>> > Suggested-by: Nick Desaulniers <ndesaulniers@...gle.com>
>> > Signed-off-by: Anders Roxell <anders.roxell@...aro.org>
>>
>> I believe this is the better solution:
>>
>> https://lore.kernel.org/r/20210115192622.3828545-1-natechancellor@gmail.com/
>
>Yes, I agree.
>
>Cheers,
>Anders

http://lore.kernel.org/r/20201202010850.jibrjpyu6xgkff5p@google.com
Personally I'd drop DWARF v2 as an option.