linux-kernel - Re: [PATCH][next] drm/vkms: Fix missing kmalloc allocation failure check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210115205838.7hff6mmyyl55pgek@smtp.gmail.com>
Date:   Fri, 15 Jan 2021 17:58:38 -0300
From:   Melissa Wen <melissa.srw@...il.com>
To:     Sumera Priyadarsini <sylphrenadin@...il.com>
Cc:     Colin King <colin.king@...onical.com>,
        Rodrigo Siqueira <rodrigosiqueiramelo@...il.com>,
        Haneen Mohammed <hamohammed.sa@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>,
        dri-devel@...ts.freedesktop.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] drm/vkms: Fix missing kmalloc allocation failure
 check

On 01/15, Sumera Priyadarsini wrote:
> On Fri, Jan 15, 2021 at 6:39 PM Colin King <colin.king@...onical.com> wrote:
> >
> > From: Colin Ian King <colin.king@...onical.com>
> >
> > Currently the kmalloc allocation for config is not being null
> > checked and could potentially lead to a null pointer dereference.
> > Fix this by adding the missing null check.
> >
> > Addresses-Coverity: ("Dereference null return value")
> > Fixes: 2df7af93fdad ("drm/vkms: Add vkms_config type")
> > Signed-off-by: Colin Ian King <colin.king@...onical.com>
> 
> Good catch, thank you!
> 
> Reviewed-by: Sumera Priyadarsini <sylphrenadin@...il.com>

Applied to drm-misc-next.

Thanks,
Melissa Wen
> > ---
> >  drivers/gpu/drm/vkms/vkms_drv.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> > index 708f7f54001d..2173b82606f6 100644
> > --- a/drivers/gpu/drm/vkms/vkms_drv.c
> > +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> > @@ -188,7 +188,11 @@ static int vkms_create(struct vkms_config *config)
> >
> >  static int __init vkms_init(void)
> >  {
> > -       struct vkms_config *config = kmalloc(sizeof(*config), GFP_KERNEL);
> > +       struct vkms_config *config;
> > +
> > +       config = kmalloc(sizeof(*config), GFP_KERNEL);
> > +       if (!config)
> > +               return -ENOMEM;
> >
> >         default_config = config;
> >
> > --
> > 2.29.2
> >
> regards,
> Sumera