linux-kernel - Re: [PATCH] libperf tests: Avoid uninitialized variable warning.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210115083420.GA1470103@krava>
Date:   Fri, 15 Jan 2021 09:34:20 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Ian Rogers <irogers@...gle.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-kernel@...r.kernel.org, Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH] libperf tests: Avoid uninitialized variable warning.

On Thu, Jan 14, 2021 at 01:23:04PM -0800, Ian Rogers wrote:
> The variable bf is read (for a write call) without being initialized
> triggering a memory sanitizer warning. Use bf in the read and switch the
> write to reading from a string.
> 
> Signed-off-by: Ian Rogers <irogers@...gle.com>

Acked-by: Jiri Olsa <jolsa@...hat.com>

thanks,
jirka

> ---
>  tools/lib/perf/tests/test-evlist.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/lib/perf/tests/test-evlist.c b/tools/lib/perf/tests/test-evlist.c
> index 6d8ebe0c2504..1b225fe34a72 100644
> --- a/tools/lib/perf/tests/test-evlist.c
> +++ b/tools/lib/perf/tests/test-evlist.c
> @@ -208,7 +208,6 @@ static int test_mmap_thread(void)
>  	char path[PATH_MAX];
>  	int id, err, pid, go_pipe[2];
>  	union perf_event *event;
> -	char bf;
>  	int count = 0;
>  
>  	snprintf(path, PATH_MAX, "%s/kernel/debug/tracing/events/syscalls/sys_enter_prctl/id",
> @@ -229,6 +228,7 @@ static int test_mmap_thread(void)
>  	pid = fork();
>  	if (!pid) {
>  		int i;
> +		char bf;
>  
>  		read(go_pipe[0], &bf, 1);
>  
> @@ -266,7 +266,7 @@ static int test_mmap_thread(void)
>  	perf_evlist__enable(evlist);
>  
>  	/* kick the child and wait for it to finish */
> -	write(go_pipe[1], &bf, 1);
> +	write(go_pipe[1], "A", 1);
>  	waitpid(pid, NULL, 0);
>  
>  	/*
> -- 
> 2.30.0.296.g2bfb1c46d8-goog
>