linux-kernel - Re: [PATCH v2] mm/hugetlb: avoid unnecessary hugetlb_acct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f7b7e94-f803-11e4-6fc8-f510e01d2305@huawei.com>
Date:   Fri, 15 Jan 2021 17:44:08 +0800
From:   Miaohe Lin <linmiaohe@...wei.com>
To:     Oscar Salvador <osalvador@...e.de>,
        Andrew Morton <akpm@...ux-foundation.org>
CC:     <mike.kravetz@...cle.com>, <david@...hat.com>,
        <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] mm/hugetlb: avoid unnecessary hugetlb_acct_memory()
 call

Hi:

On 2021/1/15 17:28, Oscar Salvador wrote:
> On Fri, Jan 15, 2021 at 04:20:13AM -0500, Miaohe Lin wrote:
>> When gbl_reserve is 0, hugetlb_acct_memory() will do nothing except holding
>> and releasing hugetlb_lock. We should avoid this unnecessary hugetlb_lock
>> lock/unlock cycle which is happening on 'most' hugetlb munmap operations by
>> check delta against 0 at the beginning of hugetlb_acct_memory.
>>
>> Reviewed-by: David Hildenbrand <david@...hat.com>
>> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> 
> I would avoid mentioning gbl_reserve as not all callers use it, and focus
> on what delta means:
> 
> "When reservation accounting remains unchanged..", but anyway:

Sounds good. Maybe Andrew could kindly do this if this patch is picked up ?

> 
> Reviewed-by: Oscar Salvador <osalvador@...e.de>
> 
> 

Many thanks for your review.