linux-kernel - Re: [PATCH][next] drm/amdgpu: Add missing BOOTUP_DEFAULT to profile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f57062ac-499d-95bb-cf4f-bb7b5b1dea5b@wanadoo.fr>
Date:   Fri, 15 Jan 2021 11:07:36 +0100
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Colin Ian King <colin.king@...onical.com>,
        Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Xiaojian Du <Xiaojian.Du@....com>,
        amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] drm/amdgpu: Add missing BOOTUP_DEFAULT to
 profile_name[]

Le 15/01/2021 à 10:37, Colin Ian King a écrit :
> On 12/01/2021 10:07, Dan Carpenter wrote:
>> On Mon, Jan 11, 2021 at 11:46:38AM +0000, Colin King wrote:
>>> From: Colin Ian King <colin.king@...onical.com>
>>>
>>> A recent change added a new BOOTUP_DEFAULT power profile mode
>>> to the PP_SMC_POWER_PROFILE enum but omitted updating the
>>> corresponding profile_name array.  Fix this by adding in the
>>> missing BOOTUP_DEFAULT to profile_name[].
>>>
>>
>> Still not enough to prevent the array overflow.  It needs POWERSAVE as
>> well.
> 
> Thanks for checking, but there is a 1-to-1 relation ship now:
> 
> enum PP_SMC_POWER_PROFILE {
>          PP_SMC_POWER_PROFILE_BOOTUP_DEFAULT = 0x0,
>          PP_SMC_POWER_PROFILE_FULLSCREEN3D = 0x1,
>          PP_SMC_POWER_PROFILE_POWERSAVING  = 0x2,
>          PP_SMC_POWER_PROFILE_VIDEO        = 0x3,
>          PP_SMC_POWER_PROFILE_VR           = 0x4,
>          PP_SMC_POWER_PROFILE_COMPUTE      = 0x5,
>          PP_SMC_POWER_PROFILE_CUSTOM       = 0x6,
>          PP_SMC_POWER_PROFILE_COUNT,
> };
> 
> vs
> 
>          static const char *profile_name[] = {
>                                          "BOOTUP_DEFAULT",
>                                          "3D_FULL_SCREEN",
>                                          "POWER_SAVING",

This line has been added yesterday in commit f727ebeb589d.
So Dan was right when he sent his patch, but some else fixed it.

CJ

>                                          "VIDEO",
>                                          "VR",
>                                          "COMPUTE",
>                                          "CUSTOM"};
> 
> 
> unless I'm missing something because I've not had enough coffee.
> 
> Colin
> 
>>
>> regards,
>> dan carpenter
>>
> 
>