linux-kernel - Re: [PATCH v2 2/2] kbuild: handle excessively long argument lists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKwvOdnfm9XvKsgn30HSUYoCSibHND-JSTqNH0yU7bfpYog_3w@mail.gmail.com>
Date:   Thu, 14 Jan 2021 17:00:56 -0800
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Jeff Johnson <jjohnson@...eaurora.org>
Cc:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Prasad Sodagudi <psodagud@...cinc.com>,
        Elliot Berman <eberman@...cinc.com>,
        Mahesh Kumar Kalikot Veetil <mkalikot@...eaurora.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        LKML <linux-kernel@...r.kernel.org>,
        Sami Tolvanen <samitolvanen@...gle.com>
Subject: Re: [PATCH v2 2/2] kbuild: handle excessively long argument lists

On Thu, Jan 14, 2021 at 1:50 PM Jeff Johnson <jjohnson@...eaurora.org> wrote:
>
> From: Mahesh Kumar Kalikot Veetil <mkalikot@...eaurora.org>
>
> Modules with a large number of compilation units may be
> exceeding AR and LD command argument list. Handle this gracefully by
> writing the long argument list in a file. The command line options
> read from file are inserted in place of the original @file option.
>
> The usage is well documented at
> https://www.gnu.org/software/make/manual/html_node/File-Function.html
>
> Signed-off-by: Mahesh Kumar Kalikot Veetil <mkalikot@...eaurora.org>
> Signed-off-by: Jeff Johnson <jjohnson@...eaurora.org>
> ---
>
> Changes in v2:
>   - Remove spurious endif
>
> scripts/Makefile.build | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> index 252b7d2..787dca2 100644
> --- a/scripts/Makefile.build
> +++ b/scripts/Makefile.build
> @@ -425,7 +425,10 @@ $(obj)/lib.a: $(lib-y) FORCE
>  # module is turned into a multi object module, $^ will contain header file
>  # dependencies recorded in the .*.cmd file.
>  quiet_cmd_link_multi-m = LD [M]  $@
> -      cmd_link_multi-m = $(LD) $(ld_flags) -r -o $@ $(filter %.o,$^)
> +      cmd_link_multi-m =                                       \
> +       $(file >$@.in,$(filter %.o,$^))                         \
> +       $(LD) $(ld_flags) -r -o $@ @$@.in;                      \
> +       rm -f $@.in

The GNU Make docs linked above use an `@` before the invocation of
`rm`. I don't know what that's about, but that or even this patch
doesn't affect my ability to build negatively. LGTM

Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>
Tested-by: Nick Desaulniers <ndesaulniers@...gle.com>

>
>  $(multi-used-m): FORCE
>         $(call if_changed,link_multi-m)
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>


-- 
Thanks,
~Nick Desaulniers