linux-kernel - Re: [PATCH][next] scsi: pm80xx: clean up indentation of a code block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMGffEnkfgwSQKSwr_91a8wakhEvGy3fU5m_DM9O5mpp3foNSA@mail.gmail.com>
Date:   Fri, 15 Jan 2021 11:33:35 +0100
From:   Jinpu Wang <jinpu.wang@...ud.ionos.com>
To:     Colin King <colin.king@...onical.com>
Cc:     "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        Linux SCSI Mailinglist <linux-scsi@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] scsi: pm80xx: clean up indentation of a code block

On Fri, Jan 15, 2021 at 10:58 AM Colin King <colin.king@...onical.com> wrote:
>
> From: Colin Ian King <colin.king@...onical.com>
>
> A block of code is indented one level too deeply, clean this
> up.
>
> Addresses-Coverity: ("Indentation does not match nesting level")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
Acked-by: Jack Wang <jinpu.wang@...ud.ionos.com>
> ---
>  drivers/scsi/pm8001/pm80xx_hwi.c | 34 ++++++++++++++------------------
>  1 file changed, 15 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c
> index e7fef42b4f6c..6fd206abc9fc 100644
> --- a/drivers/scsi/pm8001/pm80xx_hwi.c
> +++ b/drivers/scsi/pm8001/pm80xx_hwi.c
> @@ -358,26 +358,22 @@ ssize_t pm80xx_get_fatal_dump(struct device *cdev,
>                                         MEMBASE_II_SHIFT_REGISTER,
>                                         pm8001_ha->fatal_forensic_shift_offset);
>                 }
> -                       /* Read the next block of the debug data.*/
> -                       length_to_read = pm8001_mr32(fatal_table_address,
> -                       MPI_FATAL_EDUMP_TABLE_ACCUM_LEN) -
> -                       pm8001_ha->forensic_preserved_accumulated_transfer;
> -                       if (length_to_read != 0x0) {
> -                               pm8001_ha->forensic_fatal_step = 0;
> -                               goto moreData;
> -                       } else {
> -                               pm8001_ha->forensic_info.data_buf.direct_data +=
> -                               sprintf(
> -                               pm8001_ha->forensic_info.data_buf.direct_data,
> +               /* Read the next block of the debug data.*/
> +               length_to_read = pm8001_mr32(fatal_table_address,
> +               MPI_FATAL_EDUMP_TABLE_ACCUM_LEN) -
> +               pm8001_ha->forensic_preserved_accumulated_transfer;
> +               if (length_to_read != 0x0) {
> +                       pm8001_ha->forensic_fatal_step = 0;
> +                       goto moreData;
> +               } else {
> +                       pm8001_ha->forensic_info.data_buf.direct_data +=
> +                       sprintf(pm8001_ha->forensic_info.data_buf.direct_data,
>                                 "%08x ", 4);
> -                               pm8001_ha->forensic_info.data_buf.read_len
> -                                                               = 0xFFFFFFFF;
> -                               pm8001_ha->forensic_info.data_buf.direct_len
> -                                                               =  0;
> -                               pm8001_ha->forensic_info.data_buf.direct_offset
> -                                                               = 0;
> -                               pm8001_ha->forensic_info.data_buf.read_len = 0;
> -                       }
> +                       pm8001_ha->forensic_info.data_buf.read_len = 0xFFFFFFFF;
> +                       pm8001_ha->forensic_info.data_buf.direct_len =  0;
> +                       pm8001_ha->forensic_info.data_buf.direct_offset = 0;
> +                       pm8001_ha->forensic_info.data_buf.read_len = 0;
> +               }
>         }
>         offset = (int)((char *)pm8001_ha->forensic_info.data_buf.direct_data
>                         - (char *)buf);
> --
> 2.29.2
>