| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 Jan 2021 20:33:03 +0800
From: kernel test robot <lkp@...el.com>
To: Edward Cree <ecree@...arflare.com>
Cc: kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
linux-kernel@...r.kernel.org
Subject: drivers/net/ethernet/sfc/farch.c:1257:5: warning: stack frame size
of 1072 bytes in function 'efx_farch_ev_process'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 5ee88057889bbca5f5bb96031b62b3756b33e164
commit: 35ff765f8d508e56d09ef470395324298550c415 sfc: fix W=1 warnings in efx_farch_handle_rx_not_ok
date: 5 months ago
config: powerpc64-randconfig-r025-20210115 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 6077d55381a6aa3e947ef7abdc36a7515c598c8a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc64 cross compiling tool for clang build
# apt-get install binutils-powerpc64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=35ff765f8d508e56d09ef470395324298550c415
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 35ff765f8d508e56d09ef470395324298550c415
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
>> drivers/net/ethernet/sfc/farch.c:1257:5: warning: stack frame size of 1072 bytes in function 'efx_farch_ev_process' [-Wframe-larger-than=]
int efx_farch_ev_process(struct efx_channel *channel, int budget)
^
1 warning generated.
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for ATA
Depends on HAS_IOMEM && BLOCK
Selected by
- AKEBONO && PPC_47x
WARNING: unmet direct dependencies detected for NETDEVICES
Depends on NET
Selected by
- AKEBONO && PPC_47x
WARNING: unmet direct dependencies detected for ETHERNET
Depends on NETDEVICES && NET
Selected by
- AKEBONO && PPC_47x
WARNING: unmet direct dependencies detected for HOTPLUG_CPU
Depends on SMP && (PPC_PSERIES || PPC_PMAC || PPC_POWERNV || FSL_SOC_BOOKE
Selected by
- PM_SLEEP_SMP && SMP && (ARCH_SUSPEND_POSSIBLE || ARCH_HIBERNATION_POSSIBLE && PM_SLEEP
WARNING: unmet direct dependencies detected for NET_DEVLINK
Depends on NET
Selected by
- ICE && NETDEVICES && ETHERNET && NET_VENDOR_INTEL && PCI_MSI
- MLX5_CORE && NETDEVICES && ETHERNET && NET_VENDOR_MELLANOX && PCI && (VXLAN || !VXLAN && (MLXFW || !MLXFW && (PTP_1588_CLOCK || !PTP_1588_CLOCK && (PCI_HYPERV_INTERFACE || !PCI_HYPERV_INTERFACE
- MLXSW_CORE && NETDEVICES && ETHERNET && NET_VENDOR_MELLANOX
- MLXFW && NETDEVICES && ETHERNET && NET_VENDOR_MELLANOX
WARNING: unmet direct dependencies detected for GRO_CELLS
Depends on NET
Selected by
- RMNET && NETDEVICES && ETHERNET && NET_VENDOR_QUALCOMM
WARNING: unmet direct dependencies detected for FAILOVER
Depends on NET
Selected by
- NET_FAILOVER && NETDEVICES
WARNING: unmet direct dependencies detected for PAGE_POOL
Depends on NET
Selected by
- STMMAC_ETH && NETDEVICES && ETHERNET && NET_VENDOR_STMICRO && HAS_IOMEM && HAS_DMA
vim +/efx_farch_ev_process +1257 drivers/net/ethernet/sfc/farch.c
86094f7f38ff711f Ben Hutchings 2013-08-21 1256
86094f7f38ff711f Ben Hutchings 2013-08-21 @1257 int efx_farch_ev_process(struct efx_channel *channel, int budget)
86094f7f38ff711f Ben Hutchings 2013-08-21 1258 {
86094f7f38ff711f Ben Hutchings 2013-08-21 1259 struct efx_nic *efx = channel->efx;
86094f7f38ff711f Ben Hutchings 2013-08-21 1260 unsigned int read_ptr;
86094f7f38ff711f Ben Hutchings 2013-08-21 1261 efx_qword_t event, *p_event;
86094f7f38ff711f Ben Hutchings 2013-08-21 1262 int ev_code;
86094f7f38ff711f Ben Hutchings 2013-08-21 1263 int spent = 0;
86094f7f38ff711f Ben Hutchings 2013-08-21 1264
75363a4676cdb046 Eric W. Biederman 2014-03-14 1265 if (budget <= 0)
75363a4676cdb046 Eric W. Biederman 2014-03-14 1266 return spent;
75363a4676cdb046 Eric W. Biederman 2014-03-14 1267
86094f7f38ff711f Ben Hutchings 2013-08-21 1268 read_ptr = channel->eventq_read_ptr;
86094f7f38ff711f Ben Hutchings 2013-08-21 1269
86094f7f38ff711f Ben Hutchings 2013-08-21 1270 for (;;) {
86094f7f38ff711f Ben Hutchings 2013-08-21 1271 p_event = efx_event(channel, read_ptr);
86094f7f38ff711f Ben Hutchings 2013-08-21 1272 event = *p_event;
86094f7f38ff711f Ben Hutchings 2013-08-21 1273
86094f7f38ff711f Ben Hutchings 2013-08-21 1274 if (!efx_event_present(&event))
86094f7f38ff711f Ben Hutchings 2013-08-21 1275 /* End of events */
86094f7f38ff711f Ben Hutchings 2013-08-21 1276 break;
86094f7f38ff711f Ben Hutchings 2013-08-21 1277
86094f7f38ff711f Ben Hutchings 2013-08-21 1278 netif_vdbg(channel->efx, intr, channel->efx->net_dev,
86094f7f38ff711f Ben Hutchings 2013-08-21 1279 "channel %d event is "EFX_QWORD_FMT"\n",
86094f7f38ff711f Ben Hutchings 2013-08-21 1280 channel->channel, EFX_QWORD_VAL(event));
86094f7f38ff711f Ben Hutchings 2013-08-21 1281
86094f7f38ff711f Ben Hutchings 2013-08-21 1282 /* Clear this event by marking it all ones */
86094f7f38ff711f Ben Hutchings 2013-08-21 1283 EFX_SET_QWORD(*p_event);
86094f7f38ff711f Ben Hutchings 2013-08-21 1284
86094f7f38ff711f Ben Hutchings 2013-08-21 1285 ++read_ptr;
86094f7f38ff711f Ben Hutchings 2013-08-21 1286
86094f7f38ff711f Ben Hutchings 2013-08-21 1287 ev_code = EFX_QWORD_FIELD(event, FSF_AZ_EV_CODE);
86094f7f38ff711f Ben Hutchings 2013-08-21 1288
86094f7f38ff711f Ben Hutchings 2013-08-21 1289 switch (ev_code) {
86094f7f38ff711f Ben Hutchings 2013-08-21 1290 case FSE_AZ_EV_CODE_RX_EV:
86094f7f38ff711f Ben Hutchings 2013-08-21 1291 efx_farch_handle_rx_event(channel, &event);
86094f7f38ff711f Ben Hutchings 2013-08-21 1292 if (++spent == budget)
86094f7f38ff711f Ben Hutchings 2013-08-21 1293 goto out;
86094f7f38ff711f Ben Hutchings 2013-08-21 1294 break;
86094f7f38ff711f Ben Hutchings 2013-08-21 1295 case FSE_AZ_EV_CODE_TX_EV:
5227ecccea2d645d Bert Kenward 2018-01-25 1296 efx_farch_handle_tx_event(channel, &event);
86094f7f38ff711f Ben Hutchings 2013-08-21 1297 break;
86094f7f38ff711f Ben Hutchings 2013-08-21 1298 case FSE_AZ_EV_CODE_DRV_GEN_EV:
86094f7f38ff711f Ben Hutchings 2013-08-21 1299 efx_farch_handle_generated_event(channel, &event);
86094f7f38ff711f Ben Hutchings 2013-08-21 1300 break;
86094f7f38ff711f Ben Hutchings 2013-08-21 1301 case FSE_AZ_EV_CODE_DRIVER_EV:
86094f7f38ff711f Ben Hutchings 2013-08-21 1302 efx_farch_handle_driver_event(channel, &event);
86094f7f38ff711f Ben Hutchings 2013-08-21 1303 break;
7fa8d547049aae54 Shradha Shah 2015-05-06 1304 #ifdef CONFIG_SFC_SRIOV
86094f7f38ff711f Ben Hutchings 2013-08-21 1305 case FSE_CZ_EV_CODE_USER_EV:
327c685eb745e3c5 Shradha Shah 2014-11-05 1306 efx_siena_sriov_event(channel, &event);
86094f7f38ff711f Ben Hutchings 2013-08-21 1307 break;
7fa8d547049aae54 Shradha Shah 2015-05-06 1308 #endif
86094f7f38ff711f Ben Hutchings 2013-08-21 1309 case FSE_CZ_EV_CODE_MCDI_EV:
86094f7f38ff711f Ben Hutchings 2013-08-21 1310 efx_mcdi_process_event(channel, &event);
86094f7f38ff711f Ben Hutchings 2013-08-21 1311 break;
86094f7f38ff711f Ben Hutchings 2013-08-21 1312 case FSE_AZ_EV_CODE_GLOBAL_EV:
86094f7f38ff711f Ben Hutchings 2013-08-21 1313 if (efx->type->handle_global_event &&
86094f7f38ff711f Ben Hutchings 2013-08-21 1314 efx->type->handle_global_event(channel, &event))
86094f7f38ff711f Ben Hutchings 2013-08-21 1315 break;
86094f7f38ff711f Ben Hutchings 2013-08-21 1316 /* else fall through */
86094f7f38ff711f Ben Hutchings 2013-08-21 1317 default:
86094f7f38ff711f Ben Hutchings 2013-08-21 1318 netif_err(channel->efx, hw, channel->efx->net_dev,
86094f7f38ff711f Ben Hutchings 2013-08-21 1319 "channel %d unknown event type %d (data "
86094f7f38ff711f Ben Hutchings 2013-08-21 1320 EFX_QWORD_FMT ")\n", channel->channel,
86094f7f38ff711f Ben Hutchings 2013-08-21 1321 ev_code, EFX_QWORD_VAL(event));
86094f7f38ff711f Ben Hutchings 2013-08-21 1322 }
86094f7f38ff711f Ben Hutchings 2013-08-21 1323 }
86094f7f38ff711f Ben Hutchings 2013-08-21 1324
86094f7f38ff711f Ben Hutchings 2013-08-21 1325 out:
86094f7f38ff711f Ben Hutchings 2013-08-21 1326 channel->eventq_read_ptr = read_ptr;
86094f7f38ff711f Ben Hutchings 2013-08-21 1327 return spent;
86094f7f38ff711f Ben Hutchings 2013-08-21 1328 }
86094f7f38ff711f Ben Hutchings 2013-08-21 1329
:::::: The code at line 1257 was first introduced by commit
:::::: 86094f7f38ff711f3db8497fcb4d2e109100f497 sfc: Move and rename Falcon/Siena common NIC operations
:::::: TO: Ben Hutchings <bhutchings@...arflare.com>
:::::: CC: Ben Hutchings <bhutchings@...arflare.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (31275 bytes)
Powered by blists - more mailing lists