[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <fc95043e-1bc4-61e1-7d83-61aa7797ae0e@gmail.com>
Date: Fri, 15 Jan 2021 15:59:05 +0300
From: Dmitry Osipenko <digetx@...il.com>
To: Ben Dooks <ben.dooks@...ethink.co.uk>,
Thierry Reding <thierry.reding@...il.com>,
Jonathan Hunter <jonathanh@...dia.com>,
Sameer Pujar <spujar@...dia.com>,
Peter Geis <pgwipeout@...il.com>,
Nicolas Chauvet <kwizart@...il.com>,
Takashi Iwai <tiwai@...e.com>, Jaroslav Kysela <perex@...ex.cz>
Cc: alsa-devel@...a-project.org, linux-tegra@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 0/5] Clock and reset improvements for Tegra ALSA
drivers
15.01.2021 13:52, Ben Dooks пишет:
> On 12/01/2021 12:58, Dmitry Osipenko wrote:
>> This series improves the handling of clock and reset controls of
>> NVIDA Tegra ALSA drivers. Tegra HDA and AHUB drivers aren't handling
>> resets properly, which needs to be fixed in order to unblock other
>> patches
>> related to fixes on the reset controller driver since HDA/AHUB are bound
>> to fail once reset controller driver will be corrected. In particular
>> ALSA
>> drivers are relying on implicit de-assertion of resets which is done
>> by the
>> tegra-clk driver. It's not the business of the clk driver to touch resets
>> and we need to fix this because it breaks reset/clk programming sequences
>> of other Tegra drivers.
>>
>> Dmitry Osipenko (5):
>> ALSA: hda/tegra: Use clk_bulk helpers
>> ALSA: hda/tegra: Reset hardware
>> ASoC: tegra: ahub: Use of_reset_control_array_get_exclusive()
>> ASoC: tegra: ahub: Use clk_bulk helpers
>> ASoC: tegra: ahub: Reset hardware properly
>>
>> sound/pci/hda/hda_tegra.c | 86 +++++++++------------------
>> sound/soc/tegra/tegra30_ahub.c | 103 ++++++---------------------------
>> sound/soc/tegra/tegra30_ahub.h | 6 +-
>> 3 files changed, 49 insertions(+), 146 deletions(-)
>
> I wonder if this will help with the issues we saw when the tegra is
> the i2s clock slave.
Probably no, this series shouldn't fix any of the current problems. I
will be surprised if it does.
Powered by blists - more mailing lists