linux-kernel - Re: [PATCH v2 3/9] KVM: arm64: Enable UBSAN_BOUNDS for the both the kernel and hyp/nVHE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 15 Jan 2021 21:37:23 +0800
From:   kernel test robot <lkp@...el.com>
To:     Elena Petrova <lenaptr@...gle.com>, kvmarm@...ts.cs.columbia.edu
Cc:     kbuild-all@...ts.01.org, Elena Petrova <lenaptr@...gle.com>,
        linux-arm-kernel@...ts.infradead.org,
        open list <linux-kernel@...r.kernel.org>,
        Marc Zyngier <maz@...nel.org>,
        James Morse <james.morse@....com>,
        Julien Thierry <julien.thierry.kdev@...il.com>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        George Popescu <george.apopescu97@...il.com>
Subject: Re: [PATCH v2 3/9] KVM: arm64: Enable UBSAN_BOUNDS for the both the
 kernel and hyp/nVHE

Hi Elena,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on arm64/for-next/core]
[cannot apply to kvmarm/next soc/for-next arm/for-next xlnx/master v5.11-rc3 next-20210115]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Elena-Petrova/UBSan-Enablement-for-hyp-nVHE-code/20210115-112509
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/c8a90dc1d55ba5e383a58cb48562cfdc803cb1b0
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Elena-Petrova/UBSan-Enablement-for-hyp-nVHE-code/20210115-112509
        git checkout c8a90dc1d55ba5e383a58cb48562cfdc803cb1b0
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from arch/arm64/kvm/kvm_ubsan_buffer.c:12:
   include/kvm/arm_pmu.h:52:15: warning: 'struct kvm_device_attr' declared inside parameter list will not be visible outside of this definition or declaration
      52 |        struct kvm_device_attr *attr);
         |               ^~~~~~~~~~~~~~~
   include/kvm/arm_pmu.h:54:15: warning: 'struct kvm_device_attr' declared inside parameter list will not be visible outside of this definition or declaration
      54 |        struct kvm_device_attr *attr);
         |               ^~~~~~~~~~~~~~~
   include/kvm/arm_pmu.h:56:15: warning: 'struct kvm_device_attr' declared inside parameter list will not be visible outside of this definition or declaration
      56 |        struct kvm_device_attr *attr);
         |               ^~~~~~~~~~~~~~~
>> arch/arm64/kvm/kvm_ubsan_buffer.c:20:6: warning: no previous prototype for '__kvm_check_ubsan_data' [-Wmissing-prototypes]
      20 | void __kvm_check_ubsan_data(struct kvm_ubsan_info *slot)
         |      ^~~~~~~~~~~~~~~~~~~~~~
   arch/arm64/kvm/kvm_ubsan_buffer.c:30:6: warning: no previous prototype for 'iterate_kvm_ubsan_buffer' [-Wmissing-prototypes]
      30 | void iterate_kvm_ubsan_buffer(unsigned long left, unsigned long right)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~
   arch/arm64/kvm/kvm_ubsan_buffer.c:43:6: warning: no previous prototype for '__kvm_check_ubsan_buffer' [-Wmissing-prototypes]
      43 | void __kvm_check_ubsan_buffer(void)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~


vim +/__kvm_check_ubsan_data +20 arch/arm64/kvm/kvm_ubsan_buffer.c

    16	
    17	DECLARE_KVM_DEBUG_BUFFER(struct kvm_ubsan_info, kvm_ubsan_buffer,
    18			kvm_ubsan_buff_wr_ind, KVM_UBSAN_BUFFER_SIZE);
    19	
  > 20	void __kvm_check_ubsan_data(struct kvm_ubsan_info *slot)
    21	{
    22		switch (slot->type) {
    23		case UBSAN_OUT_OF_BOUNDS:
    24			__ubsan_handle_out_of_bounds(&slot->out_of_bounds_data,
    25					slot->u_val.lval);
    26			break;
    27		}
    28	}
    29	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (76484 bytes)