linux-kernel - Re: [PATCH v2 1/2] power: supply: PCHG: Peripheral device charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210116130516.j3fumvkajdzh2bdq@earth.universe>
Date:   Sat, 16 Jan 2021 14:05:16 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Benson Leung <bleung@...gle.com>
Cc:     Daisuke Nojiri <dnojiri@...omium.org>, vpalatin@...omium.org,
        Lee Jones <lee.jones@...aro.org>,
        Benson Leung <bleung@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Guenter Roeck <groeck@...omium.org>,
        Prashant Malani <pmalani@...omium.org>,
        Mark Brown <broonie@...nel.org>,
        Pi-Hsun Shih <pihsun@...omium.org>,
        Alex Levin <levinale@...gle.com>,
        Gwendal Grignou <gwendal@...omium.org>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Vijay Hiremath <vijay.p.hiremath@...el.com>,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v2 1/2] power: supply: PCHG: Peripheral device charger

Hi Benson,

On Thu, Jan 14, 2021 at 10:19:44AM -0800, Benson Leung wrote:
> On Wed, Dec 16, 2020 at 08:34:15AM -0800, Daisuke Nojiri wrote:
> > This patch adds a driver for PCHG (Peripheral CHarGer). PCHG is a
> > framework managing power supplies for peripheral devices.
> > 
> > This driver creates a sysfs node for each peripheral charge port:
> > 
> > 	/sys/class/power_supply/PCHGn
> > 
> > where <n> is the index of a charge port.
> > 
> > For example, when a stylus is connected to a NFC/WLC port, the node
> > prints:
> > 
> > 	/sys/class/power_supply/PCHG0/
> > 		capacity=50
> > 		status=Charging
> > 		type=Wireless
> > 
> > Signed-off-by: Daisuke Nojiri <dnojiri@...omium.org>
> 
> This change seems reasonable to me. I've reviewed the cros_ec_commands header,
> and it looks good.
> 
> Sebastian, do you have any comments on this? I can merge this through the
> chrome/platform tree if we have your Acked-By.

There is an unresolved feedback from Guenter Roeck. I wanted to
provide a link to lore, but it looks like it did not made it
through. I guess that's why there was no further reply to his
mail.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)