[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <578023b1-ae22-f21a-3969-62f06557baf1@gmail.com>
Date: Sat, 16 Jan 2021 23:10:02 +0800
From: Perry Yuan <perry979106@...il.com>
To: Randy Dunlap <rdunlap@...radead.org>,
Perry Yuan <Perry.Yuan@...l.com>, oder_chiou@...ltek.com,
perex@...ex.cz, tiwai@...e.com, hdegoede@...hat.com,
mgross@...ux.intel.com
Cc: lgirdwood@...il.com, broonie@...nel.org,
alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
platform-driver-x86@...r.kernel.org, Mario.Limonciello@...l.com
Subject: Re: [PATCH v3 1/3] platform/x86: dell-privacy: Add support for Dell
hardware privacy
On 2021/1/13 1:39, Randy Dunlap wrote:
> On 1/12/21 9:17 AM, Perry Yuan wrote:
>> +config DELL_PRIVACY
>> + tristate "Dell Hardware Privacy Support"
>> + depends on ACPI
>> + depends on ACPI_WMI
>> + depends on INPUT
>> + depends on DELL_LAPTOP
>> + depends on LEDS_TRIGGER_AUDIO
>> + select DELL_WMI
>> + help
>> + This driver provides support for the "Dell Hardware Privacy" feature
>> + of Dell laptops.
>> + Support for a micmute and camera mute privacy will be provided as
>> + hardware button Ctrl+F4 and Ctrl+F9 hotkey
> End above with a period '.' please.
>
>> +
>> + To compile this driver as a module, choose M here: the module will
>> + be called dell_privacy.
> Please follow coding-style for Kconfig files:
>
> from Documentation/process/coding-style.rst, section 10):
>
> For all of the Kconfig* configuration files throughout the source tree,
> the indentation is somewhat different. Lines under a ``config`` definition
> are indented with one tab, while help text is indented an additional two
> spaces.
>
>
> thanks.
Thanks for your review feedback.
I will fix this in V4 patch.
Powered by blists - more mailing lists