linux-kernel - Re: [tip: x86/cleanups] x86: Remove definition of DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210116132131.GA5176@zn.tnic>
Date:   Sat, 16 Jan 2021 14:21:31 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     x86-ml <x86@...nel.org>
Cc:     linux-tip-commits@...r.kernel.org, Tom Rix <trix@...hat.com>,
        "Steven Rostedt (VMware)" <rostedt@...dmis.org>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [tip: x86/cleanups] x86: Remove definition of DEBUG

On Fri, Jan 15, 2021 at 07:44:58AM -0000, tip-bot2 for Tom Rix wrote:
> The following commit has been merged into the x86/cleanups branch of tip:
> 
> Commit-ID:     b86cb29287be07041b81f5611e37ae9ffabff876
> Gitweb:        https://git.kernel.org/tip/b86cb29287be07041b81f5611e37ae9ffabff876
> Author:        Tom Rix <trix@...hat.com>
> AuthorDate:    Thu, 14 Jan 2021 13:28:27 -08:00
> Committer:     Borislav Petkov <bp@...e.de>
> CommitterDate: Fri, 15 Jan 2021 08:23:10 +01:00
> 
> x86: Remove definition of DEBUG
> 
> Defining DEBUG should only be done in development. So remove it.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> Signed-off-by: Borislav Petkov <bp@...e.de>
> Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
> Link: https://lkml.kernel.org/r/20210114212827.47584-1-trix@redhat.com
> ---
>  arch/x86/kernel/cpu/mtrr/generic.c | 1 -
>  arch/x86/kernel/cpu/mtrr/mtrr.c    | 2 --

Btw, this removes the MTRR ranges output from dmesg - something which
we have had since forever. If you guys think it is still important for
debugging purposes, I can resurrect it by making all those pr_info.

This thing:

MTRR default type: uncachable
MTRR fixed ranges enabled:
  00000-9FFFF write-back
  A0000-BFFFF write-through
  C0000-FFFFF write-protect
MTRR variable ranges enabled:
  0 base 000000000000 mask FFFF80000000 write-back
  1 base 000080000000 mask FFFFC0000000 write-back
  2 base 0000C0000000 mask FFFFE0000000 write-back
  3 disabled
  4 disabled
  5 disabled
  6 disabled
  7 disabled
TOM2: 0000000820000000 aka 33280M

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette