linux-kernel - Re: [PATCH] In the current implementation, should_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAKvRR0QXuETjF3zMb_CBPhGt9h_WeYp8y3TVL7fK4FvS8hqQqA@mail.gmail.com>
Date:   Sun, 17 Jan 2021 02:34:10 +0800
From:   Hongwei Qin <glqinhongwei@...il.com>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH] In the current implementation, should_check_rate() …

Hi Makus,
My apology for sending to the wrong mail list. Please ignore this
email. I'll reformat it and send it to the fio maillist.

Regards,
Hongwei

On Sun, Jan 17, 2021 at 2:10 AM Markus Elfring <Markus.Elfring@....de> wrote:
>
> > This patch addresses the issue by not checking td->bytes_done in should_check_rate.
>
> I suggest to improve the change description.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=1d94330a437a573cfdf848f6743b1ed169242c8a#n89
>
> Please choose a succinct patch subject.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=1d94330a437a573cfdf848f6743b1ed169242c8a#n569
>
>
> > +++ b/fio.h
>
> Do you refer to a header file from a special repository here?
> https://github.com/axboe/fio/blame/4008b7fc8e2bff60a4e98de0005e6bc71b1a8641/fio.h#L765
>
> Regards,
> Markus