linux-kernel - RE: [PATCH] dt-bindings: mips: lantiq: Document Lantiq Xway CGU bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 16 Jan 2021 21:29:22 +0100
From:   Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To:     olek2@...pl
Cc:     devicetree@...r.kernel.org, john@...ozen.org,
        linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org,
        robh+dt@...nel.org, tsbogend@...ha.franken.de
Subject: RE: [PATCH] dt-bindings: mips: lantiq: Document Lantiq Xway CGU bindings

(sorry for only seeing this late)

[...]
> +maintainers:
> +  - John Crispin <john@...ozen.org>
personally I think we should get at least John's Acked-by but I don't
know if there's any rule for adding a dt-binding for some other
maintainer

[...]
> +required:
> +  - compatible
> +  - reg
based on "DOs and DON’Ts for designing and writing Devicetree bindings"
from [0] I think this is incomplete
As far as I know CGU contains some PLLs. These PLLs need at least one
input: the main XTAL which is found on the board

Also the Lantiq code does not use the common clock framework yet. Once
that's used we also need #clock-cells = <1>. I don't know if that
should be added already (or not).

> +examples:
> +  - |
> +    cgu@...000 {
this should be clock-controller@...


Best regards,
Martin


[0] https://www.kernel.org/doc/html/latest/devicetree/bindings/writing-bindings.html