| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 16 Jan 2021 12:00:34 +0800
From: kernel test robot <lkp@...el.com>
To: trix@...hat.com, a.hajda@...sung.com, mchehab@...nel.org
Cc: kbuild-all@...ts.01.org, linux-arm-kernel@...ts.infradead.org,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
Tom Rix <trix@...hat.com>
Subject: Re: [PATCH] [media] s5p-mfc: remove definition of DEBUG
Hi,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v5.11-rc3 next-20210115]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/trix-redhat-com/s5p-mfc-remove-definition-of-DEBUG/20210116-075755
base: git://linuxtv.org/media_tree.git master
config: sparc64-randconfig-p001-20210115 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/1da2e97c1a24861ee70902480c52eb3954e8c348
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review trix-redhat-com/s5p-mfc-remove-definition-of-DEBUG/20210116-075755
git checkout 1da2e97c1a24861ee70902480c52eb3954e8c348
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c: In function 's5p_mfc_init_hw':
>> drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c:207:15: warning: variable 'ver' set but not used [-Wunused-but-set-variable]
207 | unsigned int ver;
| ^~~
--
drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c: In function 's5p_mfc_set_dec_frame_buffer_v6':
>> drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:515:15: warning: variable 'frame_size_ch' set but not used [-Wunused-but-set-variable]
515 | unsigned int frame_size_ch, frame_size_mv;
| ^~~~~~~~~~~~~
>> drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:514:15: warning: variable 'frame_size' set but not used [-Wunused-but-set-variable]
514 | unsigned int frame_size, i;
| ^~~~~~~~~~
drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c: In function 's5p_mfc_get_enc_frame_buffer_v6':
>> drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:644:34: warning: variable 'enc_recon_c_addr' set but not used [-Wunused-but-set-variable]
644 | unsigned long enc_recon_y_addr, enc_recon_c_addr;
| ^~~~~~~~~~~~~~~~
>> drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:644:16: warning: variable 'enc_recon_y_addr' set but not used [-Wunused-but-set-variable]
644 | unsigned long enc_recon_y_addr, enc_recon_c_addr;
| ^~~~~~~~~~~~~~~~
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for COMPAT_BINFMT_ELF
Depends on COMPAT && BINFMT_ELF
Selected by
- COMPAT && SPARC64
vim +/ver +207 drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 203
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 204 /* Initialize hardware */
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 205 int s5p_mfc_init_hw(struct s5p_mfc_dev *dev)
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 206 {
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 @207 unsigned int ver;
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 208 int ret;
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 209
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 210 mfc_debug_enter();
ba5d4563c2b8396c drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c Marek Szyprowski 2017-02-08 211 if (!dev->fw_buf.virt) {
2e731e443fcc8e45 drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2013-01-03 212 mfc_err("Firmware memory is not allocated.\n");
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 213 return -EINVAL;
2e731e443fcc8e45 drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2013-01-03 214 }
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 215
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 216 /* 0. MFC reset */
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 217 mfc_debug(2, "MFC reset..\n");
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 218 s5p_mfc_clock_on();
d7dce6a3cdcfa957 drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c Kiran AVND 2014-10-21 219 dev->risc_on = 0;
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 220 ret = s5p_mfc_reset(dev);
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 221 if (ret) {
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 222 mfc_err("Failed to reset MFC - timeout\n");
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 223 return ret;
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 224 }
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 225 mfc_debug(2, "Done MFC reset..\n");
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 226 /* 1. Set DRAM base Addr */
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 227 s5p_mfc_init_memctrl(dev);
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 228 /* 2. Initialize registers of channel I/F */
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 229 s5p_mfc_clear_cmds(dev);
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 230 /* 3. Release reset signal to the RISC */
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 231 s5p_mfc_clean_dev_int_flags(dev);
d7dce6a3cdcfa957 drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c Kiran AVND 2014-10-21 232 if (IS_MFCV6_PLUS(dev)) {
d7dce6a3cdcfa957 drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c Kiran AVND 2014-10-21 233 dev->risc_on = 1;
f96f3cfa0bb8f777 drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c Jeongtae Park 2012-10-03 234 mfc_write(dev, 0x1, S5P_FIMV_RISC_ON_V6);
d7dce6a3cdcfa957 drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c Kiran AVND 2014-10-21 235 }
f96f3cfa0bb8f777 drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c Jeongtae Park 2012-10-03 236 else
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 237 mfc_write(dev, 0x3ff, S5P_FIMV_SW_RESET);
b1394dc151cba4c5 drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c Smitha T Murthy 2018-02-02 238
b1394dc151cba4c5 drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c Smitha T Murthy 2018-02-02 239 if (IS_MFCV10(dev))
b1394dc151cba4c5 drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c Smitha T Murthy 2018-02-02 240 mfc_write(dev, 0x0, S5P_FIMV_MFC_CLOCK_OFF_V10);
b1394dc151cba4c5 drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c Smitha T Murthy 2018-02-02 241
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 242 mfc_debug(2, "Will now wait for completion of firmware transfer\n");
43a1ea1f90382a6a drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c Arun Kumar K 2012-10-03 243 if (s5p_mfc_wait_for_done_dev(dev, S5P_MFC_R2H_CMD_FW_STATUS_RET)) {
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 244 mfc_err("Failed to load firmware\n");
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 245 s5p_mfc_reset(dev);
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 246 s5p_mfc_clock_off();
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 247 return -EIO;
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 248 }
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 249 s5p_mfc_clean_dev_int_flags(dev);
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 250 /* 4. Initialize firmware */
43a1ea1f90382a6a drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c Arun Kumar K 2012-10-03 251 ret = s5p_mfc_hw_call(dev->mfc_cmds, sys_init_cmd, dev);
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 252 if (ret) {
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 253 mfc_err("Failed to send command to MFC - timeout\n");
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 254 s5p_mfc_reset(dev);
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 255 s5p_mfc_clock_off();
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 256 return ret;
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 257 }
e47ccb1de5db8723 drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c Zhaowei Yuan 2014-08-13 258 mfc_debug(2, "Ok, now will wait for completion of hardware init\n");
43a1ea1f90382a6a drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c Arun Kumar K 2012-10-03 259 if (s5p_mfc_wait_for_done_dev(dev, S5P_MFC_R2H_CMD_SYS_INIT_RET)) {
e47ccb1de5db8723 drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c Zhaowei Yuan 2014-08-13 260 mfc_err("Failed to init hardware\n");
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 261 s5p_mfc_reset(dev);
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 262 s5p_mfc_clock_off();
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 263 return -EIO;
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 264 }
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 265 dev->int_cond = 0;
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 266 if (dev->int_err != 0 || dev->int_type !=
43a1ea1f90382a6a drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c Arun Kumar K 2012-10-03 267 S5P_MFC_R2H_CMD_SYS_INIT_RET) {
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 268 /* Failure. */
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 269 mfc_err("Failed to init firmware - error: %d int: %d\n",
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 270 dev->int_err, dev->int_type);
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 271 s5p_mfc_reset(dev);
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 272 s5p_mfc_clock_off();
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 273 return -EIO;
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 274 }
722b979e555d002c drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c Arun Kumar K 2013-07-09 275 if (IS_MFCV6_PLUS(dev))
f96f3cfa0bb8f777 drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c Jeongtae Park 2012-10-03 276 ver = mfc_read(dev, S5P_FIMV_FW_VERSION_V6);
f96f3cfa0bb8f777 drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c Jeongtae Park 2012-10-03 277 else
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 278 ver = mfc_read(dev, S5P_FIMV_FW_VERSION);
f96f3cfa0bb8f777 drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c Jeongtae Park 2012-10-03 279
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 280 mfc_debug(2, "MFC F/W version : %02xyy, %02xmm, %02xdd\n",
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 281 (ver >> 16) & 0xFF, (ver >> 8) & 0xFF, ver & 0xFF);
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 282 s5p_mfc_clock_off();
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 283 mfc_debug_leave();
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 284 return 0;
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 285 }
af935746781088f2 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c Kamil Debski 2011-06-21 286
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (26919 bytes)
Powered by blists - more mailing lists