linux-kernel - [PATCH] sched/fair: add protection for delta of wait time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210117123104.27589-1-benbjiang@tencent.com>
Date:   Sun, 17 Jan 2021 20:31:04 +0800
From:   Jiang Biao <benbjiang@...il.com>
To:     mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com,
        vincent.guittot@...aro.org
Cc:     dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
        mgorman@...e.de, bristot@...hat.com, linux-kernel@...r.kernel.org,
        Jiang Biao <benbjiang@...cent.com>
Subject: [PATCH] sched/fair: add protection for delta of wait time

From: Jiang Biao <benbjiang@...cent.com>

delta in update_stats_wait_end() might be negative, which would
make following statistics go wrong.

Add protection for delta of wait time, like what have been done in
update_stats_enqueue_sleeper() for deltas of sleep/block time.

Signed-off-by: Jiang Biao <benbjiang@...cent.com>
---
 kernel/sched/fair.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index c0374c1152e0..ac950ac950bc 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -917,6 +917,9 @@ update_stats_wait_end(struct cfs_rq *cfs_rq, struct sched_entity *se)
 
 	delta = rq_clock(rq_of(cfs_rq)) - schedstat_val(se->statistics.wait_start);
 
+	if ((s64)delta < 0)
+		delta = 0;
+
 	if (entity_is_task(se)) {
 		p = task_of(se);
 		if (task_on_rq_migrating(p)) {
-- 
2.21.0