linux-kernel - Re: [PATCH v2 net] skbuff: back tiny skbs with kmalloc() in __netdev_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 17 Jan 2021 03:10:07 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Alexander Lobakin <alobakin@...me>
Cc:     davem@...emloft.net, kuba@...nel.org, willemb@...gle.com,
        linmiaohe@...wei.com, edumazet@...gle.com, fw@...len.de,
        linyunsheng@...wei.com, steffen.klassert@...unet.com,
        gnault@...hat.com, dseok.yi@...sung.com, kyk.segfault@...il.com,
        viro@...iv.linux.org.uk, elver@...gle.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net] skbuff: back tiny skbs with kmalloc() in
 __netdev_alloc_skb() too

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Fri, 15 Jan 2021 15:04:40 +0000 you wrote:
> Commit 3226b158e67c ("net: avoid 32 x truesize under-estimation for
> tiny skbs") ensured that skbs with data size lower than 1025 bytes
> will be kmalloc'ed to avoid excessive page cache fragmentation and
> memory consumption.
> However, the fix adressed only __napi_alloc_skb() (primarily for
> virtio_net and napi_get_frags()), but the issue can still be achieved
> through __netdev_alloc_skb(), which is still used by several drivers.
> Drivers often allocate a tiny skb for headers and place the rest of
> the frame to frags (so-called copybreak).
> Mirror the condition to __netdev_alloc_skb() to handle this case too.
> 
> [...]

Here is the summary with links:
  - [v2,net] skbuff: back tiny skbs with kmalloc() in __netdev_alloc_skb() too
    https://git.kernel.org/netdev/net/c/66c556025d68

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html