linux-kernel - Re: [PATCH v2 1/7] selftests: gpio: rework and simplify test implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210117235437.GA6841@sol>
Date:   Mon, 18 Jan 2021 07:54:37 +0800
From:   Kent Gibson <warthog618@...il.com>
To:     linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-kselftest@...r.kernel.org, bgolaszewski@...libre.com,
        linus.walleij@...aro.org, shuah@...nel.org, bamv2005@...il.com
Subject: Re: [PATCH v2 1/7] selftests: gpio: rework and simplify test
 implementation

On Thu, Jan 07, 2021 at 10:57:25AM +0800, Kent Gibson wrote:
> The GPIO mockup selftests are overly complicated with separate
> implementations of the tests for sysfs and cdev uAPI, and with the cdev
> implementation being dependent on tools/gpio and libmount.
> 
> Rework the test implementation to provide a common test suite with a
> simplified pluggable uAPI interface.  The cdev implementation utilises
> the GPIO uAPI directly to remove the dependence on tools/gpio.
> The simplified uAPI interface removes the need for any file system mount
> checks in C, and so removes the dependence on libmount.
> 
> The rework also fixes the sysfs test implementation which has been broken
> since the device created in the multiple gpiochip case was split into
> separate devices.
> 
> Fixes: commit 8a39f597bcfd ("gpio: mockup: rework device probing")
> Signed-off-by: Kent Gibson <warthog618@...il.com>
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> ---

Just a note that the 'commit' should be removed from the Fixes tag.

That will be fixed in v3.

The patches have been reviewed from the gpio side - any feedback from the
selftest side?

Cheers,
Kent.