linux-kernel - Re: [PATCH] drm/vc4: Unify PCM card's driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hturgj8qm.wl-tiwai@suse.de>
Date:   Sun, 17 Jan 2021 08:57:53 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
Cc:     mripard@...nel.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, eric@...olt.net, daniel@...ll.ch,
        airlied@...ux.ie, stefan.wahren@...e.com, broonie@...nel.org,
        tiwai@...e.com
Subject: Re: [PATCH] drm/vc4: Unify PCM card's driver_name

On Fri, 15 Jan 2021 20:12:09 +0100,
Nicolas Saenz Julienne wrote:
> 
> User-space ALSA matches a card's driver name against an internal list of
> aliases in order to select the correct configuration for the system.
> When the driver name isn't defined, the match is performed against the
> card's name.
> 
> With the introduction of RPi4 we now have two HDMI ports with two
> distinct audio cards. This is reflected in their names, making them
> different from previous RPi versions. With this, ALSA ultimately misses
> the board's configuration on RPi4.
> 
> In order to avoid this, set "card->driver_name" to "vc4-hdmi"
> unanimously.
> 
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
> Fixes: f437bc1ec731 ("drm/vc4: drv: Support BCM2711")

Looks good to me.
Reviewed-by: Takashi Iwai <tiwai@...e.de>


thanks,

Takashi

> ---
>  drivers/gpu/drm/vc4/vc4_hdmi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
> index 97f368bc1c67..4bdc8e71b5e5 100644
> --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
> +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
> @@ -1404,6 +1404,7 @@ static int vc4_hdmi_audio_init(struct vc4_hdmi *vc4_hdmi)
>  	card->dai_link = dai_link;
>  	card->num_links = 1;
>  	card->name = vc4_hdmi->variant->card_name;
> +	card->driver_name = "vc4-hdmi";
>  	card->dev = dev;
>  	card->owner = THIS_MODULE;
>  
> -- 
> 2.29.2
>