lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 17 Jan 2021 10:48:44 +0100 From: Martin Mokrejs <mmokrejs@...d.natur.cuni.cz> To: Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org Cc: Sebastian Reichel <sre@...nel.org>, linux-pm@...r.kernel.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, nicolassaenzj@...il.com, Nicolas Saenz Julienne <nicolas.saenz@...dys.net>, "Rafael J . Wysocki" <rjw@...ysocki.net> Subject: Re: [PATCH] power: supply: fix sbs-charger build, needs REGMAP_I2C Hi Randy, thank you very much. I would not mind dropping my name but I tested the patch now with 5.4.89 so you may actually also add Tested-by: Martin Mokrejs <mmokrejs@...d.natur.cuni.cz> It also happened with 5.10.7, it is probably obvious. Thank you for quick action. Martin On 16/01/2021 22:13, Randy Dunlap wrote: > CHARGER_SBS should select REGMAP_I2C since it uses API(s) that are > provided by that Kconfig symbol. > > Fixes these errors: > > ../drivers/power/supply/sbs-charger.c:149:21: error: variable ‘sbs_regmap’ has initializer but incomplete type > static const struct regmap_config sbs_regmap = { > ../drivers/power/supply/sbs-charger.c:150:3: error: ‘const struct regmap_config’ has no member named ‘reg_bits’ > .reg_bits = 8, > ../drivers/power/supply/sbs-charger.c:155:23: error: ‘REGMAP_ENDIAN_LITTLE’ undeclared here (not in a function) > .val_format_endian = REGMAP_ENDIAN_LITTLE, /* since based on SMBus */ > ../drivers/power/supply/sbs-charger.c: In function ‘sbs_probe’: > ../drivers/power/supply/sbs-charger.c:183:17: error: implicit declaration of function ‘devm_regmap_init_i2c’; did you mean ‘devm_request_irq’? [-Werror=implicit-function-declaration] > chip->regmap = devm_regmap_init_i2c(client, &sbs_regmap); > ../drivers/power/supply/sbs-charger.c: At top level: > ../drivers/power/supply/sbs-charger.c:149:35: error: storage size of ‘sbs_regmap’ isn’t known > static const struct regmap_config sbs_regmap = { > > Fixes: feb583e37f8a ("power: supply: add sbs-charger driver") > Signed-off-by: Randy Dunlap <rdunlap@...radead.org> > Cc: Sebastian Reichel <sre@...nel.org> > Cc: linux-pm@...r.kernel.org > Cc: Martin Mokrejs <mmokrejs@...d.natur.cuni.cz> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org> > Cc: nicolassaenzj@...il.com > Cc: Nicolas Saenz Julienne <nicolas.saenz@...dys.net> > Cc: Rafael J. Wysocki <rjw@...ysocki.net> > --- > Martin, do you want Reported-by: on this? > > drivers/power/supply/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20210115.orig/drivers/power/supply/Kconfig > +++ linux-next-20210115/drivers/power/supply/Kconfig > @@ -229,6 +229,7 @@ config BATTERY_SBS > config CHARGER_SBS > tristate "SBS Compliant charger" > depends on I2C > + select REGMAP_I2C > help > Say Y to include support for SBS compliant battery chargers. > >
Powered by blists - more mailing lists