lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 17 Jan 2021 11:26:44 +0000
From:   Paul Cercueil <>
To:     David Airlie <>, Daniel Vetter <>
Cc:     Sam Ravnborg <>,,,,
        Paul Cercueil <>,,
        Andrzej Hajda <>,
        Neil Armstrong <>,
        Laurent Pinchart <>,
        Jonas Karlman <>,
        Jernej Skrabec <>
Subject: [PATCH 1/3] drm: bridge/panel: Cleanup connector on bridge detach

If we don't call drm_connector_cleanup() manually in
panel_bridge_detach(), the connector will be cleaned up with the other
DRM objects in the call to drm_mode_config_cleanup(). However, since our
drm_connector is devm-allocated, by the time drm_mode_config_cleanup()
will be called, our connector will be long gone. Therefore, the
connector must be cleaned up when the bridge is detached to avoid
use-after-free conditions.

Fixes: 13dfc0540a57 ("drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.")
Cc: <> # 4.12+
Cc: Andrzej Hajda <>
Cc: Neil Armstrong <>
Cc: Laurent Pinchart <>
Cc: Jonas Karlman <>
Cc: Jernej Skrabec <>
Signed-off-by: Paul Cercueil <>
 drivers/gpu/drm/bridge/panel.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
index 0ddc37551194..975d65c14c9c 100644
--- a/drivers/gpu/drm/bridge/panel.c
+++ b/drivers/gpu/drm/bridge/panel.c
@@ -87,6 +87,10 @@ static int panel_bridge_attach(struct drm_bridge *bridge,
 static void panel_bridge_detach(struct drm_bridge *bridge)
+	struct panel_bridge *panel_bridge = drm_bridge_to_panel_bridge(bridge);
+	struct drm_connector *connector = &panel_bridge->connector;
+	drm_connector_cleanup(connector);
 static void panel_bridge_pre_enable(struct drm_bridge *bridge)

Powered by blists - more mailing lists