linux-kernel - Re: [PATCH v2 11/13] regulator: hi6421v600-regulator: move it from staging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210118162014.GN4455@sirena.org.uk>
Date:   Mon, 18 Jan 2021 16:20:14 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Lee Jones <lee.jones@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mayulong <mayulong1@...wei.com>,
        Rob Herring <robh+dt@...nel.org>, devel@...verdev.osuosl.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 11/13] regulator: hi6421v600-regulator: move it from
 staging

On Mon, Jan 18, 2021 at 05:02:45PM +0100, Mauro Carvalho Chehab wrote:
> Mark Brown <broonie@...nel.org> escreveu:

> > If for some reason the PMIC is sufficiently fragile to need a delay
> > between enables it's not clear why the driver is doing it before
> > enabling rather than after, presumably there's issues with the regulator
> > ramping up and stabalising its output 

> I don't have any datasheets or documentation from this device, except for 
> the Linaro's official driver for Kernel 4.9 (from where this driver
> was originally ported), and a high-level documentation for this 
> hardware at 96boards site, which doesn't cover any details.

This misses the point.  To repeat, if the driver is hard coding
a delay why is the driver doing this *before* rather than *after*
enabling?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)