linux-kernel - Re: [PATCH V2] coresight: etm4x: add AMBA id for Cortex-A55 and Cortex-A75

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210118164517.GA464579@xps15>
Date:   Mon, 18 Jan 2021 09:45:17 -0700
From:   Mathieu Poirier <mathieu.poirier@...aro.org>
To:     Mike Leach <mike.leach@...aro.org>
Cc:     Chunyan Zhang <zhang.lyra@...il.com>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Coresight ML <coresight@...ts.linaro.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Bin Ji <bin.ji@...soc.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Chunyan Zhang <chunyan.zhang@...soc.com>
Subject: Re: [PATCH V2] coresight: etm4x: add AMBA id for Cortex-A55 and
 Cortex-A75

On Mon, Jan 18, 2021 at 02:19:25PM +0000, Mike Leach wrote:
> On Mon, 18 Jan 2021 at 06:56, Chunyan Zhang <zhang.lyra@...il.com> wrote:
> >
> > From: Chunyan Zhang <chunyan.zhang@...soc.com>
> >
> > Add AMBA UCI id to support Cortex-A55(Ananke) and Cortex-A75(Promethus).
> >
> > Signed-off-by: Bin Ji <bin.ji@...soc.com>
> > Signed-off-by: Chunyan Zhang <chunyan.zhang@...soc.com>
> > ---
> > Changes since v1:
> > * Addressed Mike's comments - changed to use CS_AMBA_UCI_ID().
> > ---
> >  drivers/hwtracing/coresight/coresight-etm4x-core.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c
> > index b20b6ff17cf6..8c4b0c46c8f3 100644
> > --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c
> > +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c
> > @@ -1713,6 +1713,8 @@ static const struct amba_id etm4_ids[] = {
> >         CS_AMBA_ID(0x000bb95a),                 /* Cortex-A72 */
> >         CS_AMBA_ID(0x000bb959),                 /* Cortex-A73 */
> >         CS_AMBA_UCI_ID(0x000bb9da, uci_id_etm4),/* Cortex-A35 */
> > +       CS_AMBA_UCI_ID(0x000bbd05, uci_id_etm4),/* Cortex-A55 */
> > +       CS_AMBA_UCI_ID(0x000bbd0a, uci_id_etm4),/* Cortex-A75 */
> >         CS_AMBA_UCI_ID(0x000bbd0c, uci_id_etm4),/* Neoverse N1 */
> >         CS_AMBA_UCI_ID(0x000f0205, uci_id_etm4),/* Qualcomm Kryo */
> >         CS_AMBA_UCI_ID(0x000f0211, uci_id_etm4),/* Qualcomm Kryo */
> > --
> > 2.25.1
> >
> 
> Reviewed by: Mike Leach <mike.leach@...aro.org>

I have applied this patch.

Thanks,
Mathieu

> -- 
> Mike Leach
> Principal Engineer, ARM Ltd.
> Manchester Design Centre. UK