linux-kernel - Re: [PATCH] [v3] block: Fix an error handling in add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210118113702.GB19606@quack2.suse.cz>
Date:   Mon, 18 Jan 2021 12:37:02 +0100
From:   Jan Kara <jack@...e.cz>
To:     Dinghao Liu <dinghao.liu@....edu.cn>
Cc:     kjlu@....edu, Jens Axboe <axboe@...nel.dk>,
        Jan Kara <jack@...e.cz>, Hannes Reinecke <hare@...e.de>,
        Johannes Thumshirn <johannes.thumshirn@....com>,
        Ming Lei <ming.lei@...hat.com>, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v3] block: Fix an error handling in add_partition

On Sun 17-01-21 16:53:42, Dinghao Liu wrote:
> Once we have called device_initialize(), we should use put_device() to
> give up the reference on error, just like what we have done on failure
> of device_add().
> 
> Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>

Looks good to me. You can add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
> 
> Changelog:
> 
> v2: - Refine commit message.
> 
> v3: - Add '[v3]' to the title.
> ---
>  block/partitions/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/partitions/core.c b/block/partitions/core.c
> index e7d776db803b..23460cee9de5 100644
> --- a/block/partitions/core.c
> +++ b/block/partitions/core.c
> @@ -384,7 +384,7 @@ static struct block_device *add_partition(struct gendisk *disk, int partno,
>  
>  	err = blk_alloc_devt(bdev, &devt);
>  	if (err)
> -		goto out_bdput;
> +		goto out_put;
>  	pdev->devt = devt;
>  
>  	/* delay uevent until 'holders' subdir is created */
> -- 
> 2.17.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR