linux-kernel - Re: [PATCH 1/4] MIPS: process: Reorder header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210118221137.GA5818@alpha.franken.de>
Date:   Mon, 18 Jan 2021 23:11:37 +0100
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Jinyang He <hejinyang@...ngson.cn>
Cc:     linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        Paul Burton <paulburton@...nel.org>,
        Jun-Ru Chang <jrjang@...ltek.com>
Subject: Re: [PATCH 1/4] MIPS: process: Reorder header files

On Mon, Jan 18, 2021 at 06:02:08PM +0800, Jinyang He wrote:
> On 01/15/2021 10:46 PM, Thomas Bogendoerfer wrote:
> 
> > On Tue, Jan 12, 2021 at 08:29:14PM +0800, Jinyang He wrote:
> > > Just reorder the header files.
> > This alone isn't worth a commit, IMHO. I bet there are lots of includes
> > no longer needed, so removing and sorting them is ok for me.
> > 
> > Thomas.
> > 
> 
> Hi, Thomas,
> 
> Thanks for your advice. I analyzed majority of the symbols in this file.
> The following are examples of header file references:
> 
> Space indicates that it cannot be found. (Maybe I missed it.)
> 
>     Header files                                Examples in this file
>     #include <linux/completion.h>
> *   #include <linux/cpu.h> get_online_cpus
> *   #include <linux/errno.h>                    EOPNOTSUPP
> [..]

thank you for doing this.

> By including only these header files which marked by '*', I have been able
> to compile and use certain functions (unwind_stack) normally. So are other
> header files no longer needed?
> 
> In addition, <linux/cpu.h> includes <linux/cpumask.h>, and <linux/cpumask.h>
> includes <linux/kernel.h>. What should we do?

send a patch, which deletes the not needed #includes ;-)

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]