linux-kernel - Re: [PATCH v8 3/7] mfd: Add base driver for Netronix embedded controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YATZuivr8CzHI5X2@latitude>
Date:   Mon, 18 Jan 2021 01:43:38 +0100
From:   Jonathan Neuschäfer <j.neuschaefer@....net>
To:     kernel test robot <lkp@...el.com>
Cc:     Jonathan Neuschäfer <j.neuschaefer@....net>,
        linux-kernel@...r.kernel.org, kbuild-all@...ts.01.org,
        clang-built-linux@...glegroups.com,
        Lee Jones <lee.jones@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>
Subject: Re: [PATCH v8 3/7] mfd: Add base driver for Netronix embedded
 controller

On Sun, Jan 17, 2021 at 09:22:01AM +0800, kernel test robot wrote:
[...]
> >> drivers/mfd/ntxec.c:127:10: warning: variable 'res' is uninitialized when used here [-Wuninitialized]
>                    return res;
>                           ^~~
>    drivers/mfd/ntxec.c:116:9: note: initialize the variable 'res' to silence this warning
>            int res;
>                   ^
>                    = 0
>    1 warning generated.
[...]
>    124		ec->regmap = devm_regmap_init_i2c(client, &regmap_config);
>    125		if (IS_ERR(ec->regmap)) {
>    126			dev_err(ec->dev, "Failed to set up regmap for device\n");
>  > 127			return res;
>    128		}

Ah well, that's a bug (present since v2 of the patchset). The return
statement should be:

	return PTR_ERR(ec->regmap);


Thanks,
Jonathan Neuschäfer

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)