linux-kernel - Re: [PATCH v1] cpufreq: tegra20: Use resource-managed API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 18 Jan 2021 12:09:10 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Dmitry Osipenko <digetx@...il.com>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        "Rafael J . Wysocki " <rjw@...ysocki.net>,
        linux-pm@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] cpufreq: tegra20: Use resource-managed API

On 18-01-21, 02:18, Dmitry Osipenko wrote:
> Switch cpufreq-tegra20 driver to use resource-managed API.
> This removes the need to get opp_table pointer using
> dev_pm_opp_get_opp_table() in order to release OPP table that
> was requested by dev_pm_opp_set_supported_hw(), making the code
> a bit more straightforward.
> 
> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
> ---
>  drivers/cpufreq/tegra20-cpufreq.c | 45 +++++++++++++++----------------
>  1 file changed, 22 insertions(+), 23 deletions(-)
> 
> diff --git a/drivers/cpufreq/tegra20-cpufreq.c b/drivers/cpufreq/tegra20-cpufreq.c
> index 8c893043953e..e8db3d75be25 100644
> --- a/drivers/cpufreq/tegra20-cpufreq.c
> +++ b/drivers/cpufreq/tegra20-cpufreq.c
> @@ -32,6 +32,16 @@ static bool cpu0_node_has_opp_v2_prop(void)
>  	return ret;
>  }
>  
> +static void tegra20_cpufreq_put_supported_hw(void *opp_table)
> +{
> +	dev_pm_opp_put_supported_hw(opp_table);
> +}
> +
> +static void tegra20_cpufreq_dt_unregister(void *cpufreq_dt)
> +{
> +	platform_device_unregister(cpufreq_dt);
> +}
> +
>  static int tegra20_cpufreq_probe(struct platform_device *pdev)
>  {
>  	struct platform_device *cpufreq_dt;
> @@ -68,42 +78,31 @@ static int tegra20_cpufreq_probe(struct platform_device *pdev)
>  		return err;
>  	}
>  
> +	err = devm_add_action_or_reset(&pdev->dev,
> +				       tegra20_cpufreq_put_supported_hw,
> +				       opp_table);
> +	if (err)
> +		return err;
> +
>  	cpufreq_dt = platform_device_register_simple("cpufreq-dt", -1, NULL, 0);
>  	err = PTR_ERR_OR_ZERO(cpufreq_dt);
>  	if (err) {
>  		dev_err(&pdev->dev,
>  			"failed to create cpufreq-dt device: %d\n", err);
> -		goto err_put_supported_hw;
> +		return err;
>  	}
>  
> -	platform_set_drvdata(pdev, cpufreq_dt);
> -
> -	return 0;
> -
> -err_put_supported_hw:
> -	dev_pm_opp_put_supported_hw(opp_table);
> -
> -	return err;
> -}
> -
> -static int tegra20_cpufreq_remove(struct platform_device *pdev)
> -{
> -	struct platform_device *cpufreq_dt;
> -	struct opp_table *opp_table;
> -
> -	cpufreq_dt = platform_get_drvdata(pdev);
> -	platform_device_unregister(cpufreq_dt);
> -
> -	opp_table = dev_pm_opp_get_opp_table(get_cpu_device(0));
> -	dev_pm_opp_put_supported_hw(opp_table);
> -	dev_pm_opp_put_opp_table(opp_table);
> +	err = devm_add_action_or_reset(&pdev->dev,
> +				       tegra20_cpufreq_dt_unregister,
> +				       cpufreq_dt);
> +	if (err)
> +		return err;
>  
>  	return 0;
>  }
>  
>  static struct platform_driver tegra20_cpufreq_driver = {
>  	.probe		= tegra20_cpufreq_probe,
> -	.remove		= tegra20_cpufreq_remove,
>  	.driver		= {
>  		.name	= "tegra20-cpufreq",
>  	},

Applied. Thanks.

Though please remember to update this to use the devm_ variant when it comes
out.

-- 
viresh