lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 Jan 2021 09:18:51 +0800 From: Keqian Zhu <zhukeqian1@...wei.com> To: Will Deacon <will@...nel.org> CC: <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, <kvm@...r.kernel.org>, <kvmarm@...ts.cs.columbia.edu>, Marc Zyngier <maz@...nel.org>, Catalin Marinas <catalin.marinas@....com>, Mark Rutland <mark.rutland@....com>, James Morse <james.morse@....com>, Robin Murphy <robin.murphy@....com>, Joerg Roedel <joro@...tes.org>, Daniel Lezcano <daniel.lezcano@...aro.org>, Thomas Gleixner <tglx@...utronix.de>, "Suzuki K Poulose" <suzuki.poulose@....com>, Julien Thierry <julien.thierry.kdev@...il.com>, Andrew Morton <akpm@...ux-foundation.org>, Alexios Zavras <alexios.zavras@...el.com>, <wanghaibin.wang@...wei.com>, <jiangkunkun@...wei.com> Subject: Re: [PATCH] kvm: arm64: Properly align the end address of table walk On 2021/1/15 18:23, Will Deacon wrote: > On Fri, Jan 15, 2021 at 05:53:07PM +0800, Keqian Zhu wrote: >> When align the end address, ought to use its original value. >> >> Fixes: b1e57de62cfb ("KVM: arm64: Add stand-alone page-table walker infrastructure") >> Signed-off-by: Keqian Zhu <zhukeqian1@...wei.com> >> --- >> arch/arm64/kvm/hyp/pgtable.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/kvm/hyp/pgtable.c b/arch/arm64/kvm/hyp/pgtable.c >> index bdf8e55ed308..670b0ef12440 100644 >> --- a/arch/arm64/kvm/hyp/pgtable.c >> +++ b/arch/arm64/kvm/hyp/pgtable.c >> @@ -296,7 +296,7 @@ int kvm_pgtable_walk(struct kvm_pgtable *pgt, u64 addr, u64 size, >> struct kvm_pgtable_walk_data walk_data = { >> .pgt = pgt, >> .addr = ALIGN_DOWN(addr, PAGE_SIZE), >> - .end = PAGE_ALIGN(walk_data.addr + size), >> + .end = PAGE_ALIGN(addr + size), >> .walker = walker, > > Hmm, this is a change in behaviour, no (consider the case where both 'addr' > and 'size' are misaligned)? The current code is consistent with the > kerneldoc in asm/kvm_pgtable.h, so I don't see the motivation to change it. > > Did you hit a bug somewhere? > > Will > . > Not hit a bug, I just read the code to implement a new idea of stage2 DBM support [1]. Yes, according to doc, this is not an issue ("The offset of @addr within a page is ignored."). Sorry to disturb ;-). [1] https://lore.kernel.org/kvmarm/fd26654b-8258-061c-2a69-90b961c1c71b@huawei.com/ Thanks, Keqian
Powered by blists - more mailing lists