linux-kernel - Re: [PATCH] mips: cacheinfo: Remove unnecessary increment of level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f86e131-c799-ac6f-83a6-4780f52b38df@flygoat.com>
Date:   Mon, 18 Jan 2021 09:54:36 +0800
From:   Jiaxun Yang <jiaxun.yang@...goat.com>
To:     Souptick Joarder <jrdr.linux@...il.com>, tsbogend@...ha.franken.de,
        yangtiezhu@...ngson.cn
Cc:     linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mips: cacheinfo: Remove unnecessary increment of level

在 2021/1/16 下午4:40, Souptick Joarder 写道:
> kernel test robot throws below warning ->
>
> arch/mips/kernel/cacheinfo.c:112:3: warning: Variable 'level' is
> modified but its new value is never used. [unreadVariable]
>
> Remove unnecessary increment of level at the end.
>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>

Reviewed-by: Jiaxun Yang <jiaxun.yang@...goat.com>

> ---
>   arch/mips/kernel/cacheinfo.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/arch/mips/kernel/cacheinfo.c b/arch/mips/kernel/cacheinfo.c
> index 5f9d0eb..c858ae3 100644
> --- a/arch/mips/kernel/cacheinfo.c
> +++ b/arch/mips/kernel/cacheinfo.c
> @@ -109,7 +109,6 @@ static int __populate_cache_leaves(unsigned int cpu)
>   
>   	if (c->tcache.waysize) {
>   		populate_cache(tcache, this_leaf, level, CACHE_TYPE_UNIFIED);
> -		level++;
>   	}
>   
>   	this_cpu_ci->cpu_map_populated = true;