linux-kernel - Re: [PATCH v17 02/10] fs/ntfs3: Add initialization of super block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210118140931.e2qdposfez2jsbbr@kari-VirtualBox>
Date:   Mon, 18 Jan 2021 16:09:31 +0200
From:   Kari Argillander <kari.argillander@...il.com>
To:     Konstantin Komarov <almaz.alexandrovich@...agon-software.com>
Cc:     "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "pali@...nel.org" <pali@...nel.org>,
        "dsterba@...e.cz" <dsterba@...e.cz>,
        "aaptel@...e.com" <aaptel@...e.com>,
        "willy@...radead.org" <willy@...radead.org>,
        "rdunlap@...radead.org" <rdunlap@...radead.org>,
        "joe@...ches.com" <joe@...ches.com>,
        "mark@...mstone.com" <mark@...mstone.com>,
        "nborisov@...e.com" <nborisov@...e.com>,
        "linux-ntfs-dev@...ts.sourceforge.net" 
        <linux-ntfs-dev@...ts.sourceforge.net>,
        "anton@...era.com" <anton@...era.com>,
        "dan.carpenter@...cle.com" <dan.carpenter@...cle.com>,
        "hch@....de" <hch@....de>,
        "ebiggers@...nel.org" <ebiggers@...nel.org>,
        "andy.lavr@...il.com" <andy.lavr@...il.com>
Subject: Re: [PATCH v17 02/10] fs/ntfs3: Add initialization of super block

On Mon, Jan 18, 2021 at 09:35:05AM +0000, Konstantin Komarov wrote:
> From: Kari Argillander <kari.argillander@...il.com>
> Sent: Sunday, January 3, 2021 10:50 PM
> > On Thu, Dec 31, 2020 at 06:23:53PM +0300, Konstantin Komarov wrote:
> > > diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c
> > 
> > > +int ntfs_create_inode(struct inode *dir, struct dentry *dentry,
> > > +		      const struct cpu_str *uni, umode_t mode, dev_t dev,
> > > +		      const char *symname, u32 size, int excl,
> > > +		      struct ntfs_fnd *fnd, struct inode **new_inode)
> > > +{
> > 
> > > +#ifdef CONFIG_NTFS3_FS_POSIX_ACL
> > 
> > In Kconfig this is NTFS3_POSIX_ACL. This repeat every file.
> > 
> 
> This is OK. You may refer to similar parts of ext4/btrfs sources as a
> reference:
> fs/ext4/Kconfig or fs/btrfs/Kconfig
> 

But in ext4 and btrfs Kconfig specify *_FS_POSIX_ACL. In ntfs3 Kconfig
specify *_POSIX_ACL. So we missing _FS_ in our Kconfig?