linux-kernel - Re: [PATCH] drivers/pinctrl/bcm: Simplify bool comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 18 Jan 2021 16:29:19 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Ray Jui <ray.jui@...adcom.com>
Cc:     Jiapeng Zhong <abaci-bugfix@...ux.alibaba.com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers/pinctrl/bcm: Simplify bool comparison

On Fri, Jan 15, 2021 at 7:24 PM Ray Jui <ray.jui@...adcom.com> wrote:

> > -             if ((pull_up == false) && (pull_down == false))
> > +             if (!pull_up && !pull_down)
>
> Looks fine as improvement, but I'm curious why there's a warning to
> start with.

There is no semantic difference. This is a purely syntactic warning.

Yours,
Linus Walleij