linux-kernel - Re: [PATCH v3 2/3] reset: mchp: sparx5: add switch reset driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210119203938.GQ3666@piout.net>
Date:   Tue, 19 Jan 2021 21:39:38 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Steen Hegelund <steen.hegelund@...rochip.com>
Cc:     Philipp Zabel <p.zabel@...gutronix.de>,
        Andrew Lunn <andrew@...n.ch>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        Gregory Clement <gregory.clement@...tlin.com>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 2/3] reset: mchp: sparx5: add switch reset driver

On 19/01/2021 21:37:16+0100, Alexandre Belloni wrote:
> On 14/01/2021 17:24:31+0100, Steen Hegelund wrote:
> > +static int sparx5_switch_reset(struct reset_controller_dev *rcdev,
> > +			       unsigned long id)
> > +{
> > +	struct mchp_reset_context *ctx =
> > +		container_of(rcdev, struct mchp_reset_context, rcdev);
> > +	u32 val;
> > +
> 
> I would ensure the reset only happens once here else I'm not sure how
> you could do it from the individual drivers.
> 

Ok, the core is taking care of that, nice.


-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com