linux-kernel - Re: [PATCH v1 1/1] arm64: dts: stingray: fix usb dma address translation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Jan 2021 09:44:18 -0800
From:   Ray Jui <ray.jui@...adcom.com>
To:     Rayagonda Kokatanur <rayagonda.kokatanur@...adcom.com>,
        Rob Herring <robh+dt@...nel.org>, Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com,
        Arnd Bergmann <arnd@...db.de>,
        Florian Fainelli <f.fainelli@...il.com>,
        Zhen Lei <thunder.leizhen@...wei.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Cc:     Bharat Gooty <bharat.gooty@...adcom.com>
Subject: Re: [PATCH v1 1/1] arm64: dts: stingray: fix usb dma address
 translation



On 1/18/2021 9:34 PM, Rayagonda Kokatanur wrote:
> From: Bharat Gooty <bharat.gooty@...adcom.com>
> 
> Add a non-empty dma-ranges so that dma address translation
> happens.
> 
> Fixes: 2013a4b684b6 ("arm64: dts: broadcom: clear the warnings caused by empty dma-ranges")
> 
> Signed-off-by: Bharat Gooty <bharat.gooty@...adcom.com>
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@...adcom.com>
> ---
>  arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi b/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi
> index aef8f2b00778..5401a646c840 100644
> --- a/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi
> +++ b/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi
> @@ -4,11 +4,16 @@
>   */
>  	usb {
>  		compatible = "simple-bus";
> -		dma-ranges;
>  		#address-cells = <2>;
>  		#size-cells = <2>;
>  		ranges = <0x0 0x0 0x0 0x68500000 0x0 0x00400000>;
>  
> +		/*
> +		 * Internally, USB bus to the interconnect can only address up
> +		 * to 40-bit
> +		 */
> +		dma-ranges = <0 0 0 0 0x100 0x0>;
> +

Should have had my signed-off since during our internal review, I added
the above comment to explain why we set it to 40-bit here despite the
USB controller itself is capable of addressing 64-bit as Arnd pointed out.

Well, the following ack should do it too, thanks.

Acked-by: Ray Jui <ray.jui@...adcom.com>

>  		usbphy0: usb-phy@0 {
>  			compatible = "brcm,sr-usb-combo-phy";
>  			reg = <0x0 0x00000000 0x0 0x100>;
> 

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4151 bytes)